Swift: Fix a mistake in FlowSources.qll.

Author: geoffw0

swift/ql/lib/codeql/swift/dataflow/FlowSources.qll

@@ -28,7 +28,7 @@ abstract class RemoteFlowSource extends FlowSource { }
 /**
  * A data flow source of local user input that is defined through 'models as data'.
  */
-private class ExternalLocalFlowSource extends RemoteFlowSource {
+private class ExternalLocalFlowSource extends LocalFlowSource {
   ExternalLocalFlowSource() { sourceNode(this, "local") }
 
   override string getSourceType() { result = "external" }

swift/ql/test/library-tests/dataflow/flowsources/FlowSources.ql

@@ -3,5 +3,5 @@ import codeql.swift.dataflow.FlowSources
 import codeql.swift.dataflow.ExternalFlow
 import FlowConfig
 
-from RemoteFlowSource source
+from FlowSource source
 select source, concat(source.getSourceType(), ", ")

swift/ql/test/library-tests/dataflow/flowsources/FlowSourcesInline.expected

@@ -6,15 +6,15 @@
 | alamofire.swift:365:22:365:31 | .value | Unexpected result: source=remote |
 | alamofire.swift:372:23:372:32 | .value | Unexpected result: source=remote |
 | alamofire.swift:379:28:379:37 | .value | Unexpected result: source=remote |
-| alamofire.swift:389:28:389:55 | call to String.init(contentsOfFile:) | Unexpected result: source=remote |
+| alamofire.swift:389:28:389:55 | call to String.init(contentsOfFile:) | Unexpected result: source=local |
 | alamofire.swift:396:22:396:31 | .value | Unexpected result: source=remote |
 | alamofire.swift:403:22:403:31 | .value | Unexpected result: source=remote |
 | alamofire.swift:404:28:404:50 | call to String.init(contentsOf:) | Unexpected result: source=remote |
 | alamofire.swift:411:23:411:32 | .value | Unexpected result: source=remote |
 | alamofire.swift:418:22:418:31 | .value | Unexpected result: source=remote |
 | alamofire.swift:425:23:425:32 | .value | Unexpected result: source=remote |
 | alamofire.swift:431:28:431:37 | .value | Unexpected result: source=remote |
-| alamofire.swift:448:20:448:49 | call to String.init(contentsOfFile:) | Unexpected result: source=remote |
+| alamofire.swift:448:20:448:49 | call to String.init(contentsOfFile:) | Unexpected result: source=local |
 | alamofire.swift:455:23:455:32 | .data | Unexpected result: source=remote |
 | alamofire.swift:461:23:461:32 | .data | Unexpected result: source=remote |
 | customurlschemes.swift:53:44:53:54 | url | Unexpected result: source=remote |
@@ -31,14 +31,14 @@
 | customurlschemes.swift:88:28:88:39 | didUpdate | Unexpected result: source=remote |
 | customurlschemes.swift:89:28:89:65 | openURLContexts | Unexpected result: source=remote |
 | data.swift:18:20:18:54 | call to Data.init(contentsOf:options:) | Unexpected result: source=remote |
-| filemanager.swift:37:23:37:86 | call to contentsOfDirectory(at:includingPropertiesForKeys:options:) | Unexpected result: source=remote |
-| filemanager.swift:38:23:38:58 | call to contentsOfDirectory(atPath:) | Unexpected result: source=remote |
-| filemanager.swift:39:19:39:52 | call to directoryContents(atPath:) | Unexpected result: source=remote |
-| filemanager.swift:41:23:41:58 | call to subpathsOfDirectory(atPath:) | Unexpected result: source=remote |
-| filemanager.swift:42:19:42:43 | call to subpaths(atPath:) | Unexpected result: source=remote |
-| filemanager.swift:44:19:44:60 | call to destinationOfSymbolicLink(atPath:) | Unexpected result: source=remote |
-| filemanager.swift:45:15:45:56 | call to pathContentOfSymbolicLink(atPath:) | Unexpected result: source=remote |
-| filemanager.swift:47:14:47:38 | call to contents(atPath:) | Unexpected result: source=remote |
+| filemanager.swift:37:23:37:86 | call to contentsOfDirectory(at:includingPropertiesForKeys:options:) | Unexpected result: source=local |
+| filemanager.swift:38:23:38:58 | call to contentsOfDirectory(atPath:) | Unexpected result: source=local |
+| filemanager.swift:39:19:39:52 | call to directoryContents(atPath:) | Unexpected result: source=local |
+| filemanager.swift:41:23:41:58 | call to subpathsOfDirectory(atPath:) | Unexpected result: source=local |
+| filemanager.swift:42:19:42:43 | call to subpaths(atPath:) | Unexpected result: source=local |
+| filemanager.swift:44:19:44:60 | call to destinationOfSymbolicLink(atPath:) | Unexpected result: source=local |
+| filemanager.swift:45:15:45:56 | call to pathContentOfSymbolicLink(atPath:) | Unexpected result: source=local |
+| filemanager.swift:47:14:47:38 | call to contents(atPath:) | Unexpected result: source=local |
 | generics.swift:10:9:10:16 | .source1 | Unexpected result: source=remote |
 | generics.swift:11:9:11:16 | .source2 | Unexpected result: source=remote |
 | generics.swift:12:9:12:24 | call to source3() | Unexpected result: source=remote |
@@ -89,9 +89,9 @@
 | string.swift:56:21:56:44 | call to String.init(contentsOf:) | Unexpected result: source=remote |
 | string.swift:57:21:57:77 | call to String.init(contentsOf:encoding:) | Unexpected result: source=remote |
 | string.swift:59:21:59:69 | call to String.init(contentsOf:usedEncoding:) | Unexpected result: source=remote |
-| string.swift:62:21:62:48 | call to String.init(contentsOfFile:) | Unexpected result: source=remote |
-| string.swift:63:21:63:81 | call to String.init(contentsOfFile:encoding:) | Unexpected result: source=remote |
-| string.swift:64:21:64:73 | call to String.init(contentsOfFile:usedEncoding:) | Unexpected result: source=remote |
+| string.swift:62:21:62:48 | call to String.init(contentsOfFile:) | Unexpected result: source=local |
+| string.swift:63:21:63:81 | call to String.init(contentsOfFile:encoding:) | Unexpected result: source=local |
+| string.swift:64:21:64:73 | call to String.init(contentsOfFile:usedEncoding:) | Unexpected result: source=local |
 | url.swift:53:15:53:19 | .resourceBytes | Unexpected result: source=remote |
 | url.swift:60:15:60:19 | .lines | Unexpected result: source=remote |
 | url.swift:67:16:67:22 | .lines | Unexpected result: source=remote |