Skip to content

Commit b719192

Browse files
erik-kroghasgerf
andauthored
Apply suggestions from code review
Co-authored-by: Asger F <[email protected]>
1 parent 0275ea9 commit b719192

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

javascript/ql/src/Security/CWE-078/UnsafeShellCommandConstruction.qhelp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222

2323
<p>
2424
If possible, provide the dynamic arguments to the shell as an array
25-
using e.g. the <code>child_process.execFile</code> API to avoid
25+
using a safe API such as <code>child_process.execFile</code> to avoid
2626
interpretation by the shell.
2727
</p>
2828

@@ -49,7 +49,7 @@
4949
</p>
5050

5151
<p>
52-
Even worse, although less likely, a client might pass in user-controlled
52+
Even worse, a client might pass in user-controlled
5353
data not knowing that the input is interpreted as a shell command.
5454
This could allow a malicious user to provide the input <code>http://example.org; cat /etc/passwd</code>
5555
in order to execute the command <code>cat /etc/passwd</code>.
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
module.exports = function notExporterAnyWhere() {}
1+
module.exports = function notExportedAnyWhere() {}

0 commit comments

Comments
 (0)