Skip to content

Commit be187bc

Browse files
committed
Python: Make Client::HttpRequest extend ControlFlowNode
Taus poitned out that the reuqest being send off, doesn't *need* to happen on a CallNode. Someone *could* use a __setattr__ or property :\
1 parent e25079a commit be187bc

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

python/ql/src/semmle/python/web/Http.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ module Client {
121121
* conn = HTTPConnection('example.com')
122122
conn.request('GET', '/path')
123123
*/
124-
abstract class HttpRequest extends CallNode {
124+
abstract class HttpRequest extends ControlFlowNode {
125125

126126
/** Get any ControlFlowNode that is used to construct the final URL.
127127
*

python/ql/src/semmle/python/web/client/Requests.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
import python
77
private import semmle.python.web.Http
88

9-
class RequestsHttpRequest extends Client::HttpRequest {
9+
class RequestsHttpRequest extends Client::HttpRequest, CallNode {
1010
CallableValue func;
1111
string method;
1212

python/ql/src/semmle/python/web/client/StdLib.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ ClassValue httpConnectionClass() {
1818
result = Value::named("six.moves.http_client.HTTPSConnection")
1919
}
2020

21-
class HttpConnectionHttpRequest extends Client::HttpRequest {
21+
class HttpConnectionHttpRequest extends Client::HttpRequest, CallNode {
2222
CallNode constructor_call;
2323
CallableValue func;
2424

0 commit comments

Comments
 (0)