Apply suggestions from code review

Co-authored-by: Stephan Brandauer <[email protected]>

Author: tiferet

javascript/ql/experimental/adaptivethreatmodeling/lib/experimental/adaptivethreatmodeling/ATMConfig.qll

@@ -159,7 +159,7 @@ abstract class AtmConfig extends JS::TaintTracking::Configuration {
    * Holds if if `sink` is an effective sink with flow from `source` which gets used as a sink candidate for scoring
    * with the ML model.
    */
-  predicate isSinkCandidate(JS::DataFlow::PathNode sink) {
+  predicate isSinkCandidateWithFlow(JS::DataFlow::Node sink) {
     exists(JS::DataFlow::PathNode source |
       this.hasFlowPath(source, sink) and
       not AtmResultsInfo::isFlowLikelyInBaseQuery(source.getNode(), sink.getNode())

javascript/ql/experimental/adaptivethreatmodeling/test/endpoint_large_scale/ExtractEndpointDataInference.ql

@@ -23,5 +23,5 @@ private import experimental.adaptivethreatmodeling.XssThroughDomATM as XssThroug
 query predicate isSinkCandidateForQuery(
   AtmConfig::AtmConfig queryConfig, JS::DataFlow::PathNode sink
 ) {
-  queryConfig.isSinkCandidate(sink)
+  queryConfig.isSinkCandidateWithFlow(sink)
 }