Skip to content

Commit c0e65e7

Browse files
author
Benjamin Muskalla
committed
Revert "Java: Fix external flow perofrmance with future optimiser."
This reverts commit be1d4c0.
1 parent eef044f commit c0e65e7

File tree

1 file changed

+7
-12
lines changed

1 file changed

+7
-12
lines changed

java/ql/lib/semmle/code/java/dataflow/ExternalFlow.qll

Lines changed: 7 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -616,21 +616,16 @@ private predicate elementSpec(
616616
summaryModel(namespace, type, subtypes, name, signature, ext, _, _, _)
617617
}
618618

619-
private predicate relevantCallable(Callable c) { elementSpec(_, _, _, c.getName(), _, _) }
620-
621619
private string paramsStringPart(Callable c, int i) {
622-
relevantCallable(c) and
623-
(
624-
i = -1 and result = "("
625-
or
626-
exists(int n, string p | c.getParameterType(n).getErasure().toString() = p |
627-
i = 2 * n and result = p
628-
or
629-
i = 2 * n - 1 and result = "," and n != 0
630-
)
620+
i = -1 and result = "("
621+
or
622+
exists(int n, string p | c.getParameterType(n).getErasure().toString() = p |
623+
i = 2 * n and result = p
631624
or
632-
i = 2 * c.getNumberOfParameters() and result = ")"
625+
i = 2 * n - 1 and result = "," and n != 0
633626
)
627+
or
628+
i = 2 * c.getNumberOfParameters() and result = ")"
634629
}
635630

636631
/**

0 commit comments

Comments
 (0)