Skip to content

Commit c18e0aa

Browse files
committed
C++: Add a TODO comment.
1 parent ab8d1ea commit c18e0aa

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

cpp/ql/src/semmle/code/cpp/models/implementations/MemberFunction.qll

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ class ConversionConstructorModel extends ConversionConstructor, TaintFunction {
1313
override predicate hasTaintFlow(FunctionInput input, FunctionOutput output) {
1414
// taint flow from the first constructor argument to the returned object
1515
input.isParameter(0) and
16-
output.isReturnValue()
16+
output.isReturnValue() // TODO: this should be `isQualifierObject` by our current definitions, but that flow is not yet supported.
1717
}
1818
}
1919

@@ -24,7 +24,7 @@ class CopyConstructorModel extends CopyConstructor, DataFlowFunction {
2424
override predicate hasDataFlow(FunctionInput input, FunctionOutput output) {
2525
// data flow from the first constructor argument to the returned object
2626
input.isParameter(0) and
27-
output.isReturnValue()
27+
output.isReturnValue() // TODO: this should be `isQualifierObject` by our current definitions, but that flow is not yet supported.
2828
}
2929
}
3030

@@ -35,7 +35,7 @@ class MoveConstructorModel extends MoveConstructor, DataFlowFunction {
3535
override predicate hasDataFlow(FunctionInput input, FunctionOutput output) {
3636
// data flow from the first constructor argument to the returned object
3737
input.isParameter(0) and
38-
output.isReturnValue()
38+
output.isReturnValue() // TODO: this should be `isQualifierObject` by our current definitions, but that flow is not yet supported.
3939
}
4040
}
4141

0 commit comments

Comments
 (0)