Skip to content

Commit c3cd135

Browse files
committed
C++: Mark the cases we're not sure about.
1 parent cf8fa83 commit c3cd135

File tree

1 file changed

+4
-4
lines changed
  • cpp/ql/test/query-tests/Security/CWE/CWE-367/semmle

1 file changed

+4
-4
lines changed

cpp/ql/test/query-tests/Security/CWE/CWE-367/semmle/test2.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -226,7 +226,7 @@ void test3_1(const char *path)
226226

227227
fclose(f);
228228

229-
chmod(path, 0); // BAD
229+
chmod(path, 0); // BAD???
230230
}
231231
}
232232

@@ -266,7 +266,7 @@ void test4_1(const char *path1, const char *path2)
266266
{
267267
if (!rename(path1, path2))
268268
{
269-
remove(path1); // BAD
269+
remove(path1); // BAD???
270270
}
271271
}
272272

@@ -276,7 +276,7 @@ void test4_2(const char *path1, const char *path2)
276276
{
277277
// ...
278278
} else {
279-
remove(path1); // BAD
279+
remove(path1); // BAD???
280280
}
281281
}
282282

@@ -296,7 +296,7 @@ void test4_4(const char *path1, const char *path2)
296296

297297
if (rename(path1, path2))
298298
{
299-
f = fopen(path2, "r"); // BAD [NOT DETECTED]
299+
f = fopen(path2, "r"); // BAD??? [NOT DETECTED]
300300
}
301301
}
302302

0 commit comments

Comments
 (0)