Skip to content

Commit c3fa3f2

Browse files
committed
Python: Fix problems with missing TAttributeContent
1 parent 943b2a2 commit c3fa3f2

File tree

3 files changed

+1
-16
lines changed

3 files changed

+1
-16
lines changed

python/ql/lib/semmle/python/dataflow/new/internal/DataFlowPublic.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -614,7 +614,7 @@ newtype TContent =
614614
// instead we use a qltest to alert if we write a new summary in QL that uses an
615615
// attribute -- see
616616
// python/ql/test/experimental/dataflow/summaries-checks/missing-attribute-content.ql
617-
none() // to be filled out in next commit
617+
attr in ["re", "string", "pattern"]
618618
or
619619
//
620620
// 2) summaries in data-extension files
Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,2 @@
1-
| compiled re.Match | Argument[self].Attribute[pattern] | Attribute[pattern] |
2-
| compiled re.Match | ReturnValue.Attribute[re].Attribute[pattern] | Attribute[pattern] |
3-
| compiled re.Match | ReturnValue.Attribute[re].Attribute[pattern] | Attribute[re] |
4-
| compiled re.Match | ReturnValue.Attribute[string] | Attribute[string] |
51
| compiled re.subn | ReturnValue.TupleElement[0] | TupleElement[0] |
6-
| re.Match | ReturnValue.Attribute[re].Attribute[pattern] | Attribute[pattern] |
7-
| re.Match | ReturnValue.Attribute[re].Attribute[pattern] | Attribute[re] |
8-
| re.Match | ReturnValue.Attribute[string] | Attribute[string] |
9-
| re.Match.expand | Argument[self].Attribute[string] | Attribute[string] |
10-
| re.Match.group | Argument[self].Attribute[string] | Attribute[string] |
11-
| re.Match.groupdict | Argument[self].Attribute[string] | Attribute[string] |
12-
| re.Match.groups | Argument[self].Attribute[string] | Attribute[string] |
13-
| re.Pattern | ReturnValue.Attribute[pattern] | Attribute[pattern] |
142
| re.subn | ReturnValue.TupleElement[0] | TupleElement[0] |
Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +0,0 @@
1-
| The attribute "pattern" is not a valid TAttributeContent, please add it to the hardcoded list of TAttributeContent in the dataflow library. |
2-
| The attribute "re" is not a valid TAttributeContent, please add it to the hardcoded list of TAttributeContent in the dataflow library. |
3-
| The attribute "string" is not a valid TAttributeContent, please add it to the hardcoded list of TAttributeContent in the dataflow library. |

0 commit comments

Comments
 (0)