Skip to content

Commit ceaf2b3

Browse files
committed
JS: Rename FlowSteps::callback -> exploratoryCallbackStep
1 parent 7c94dd9 commit ceaf2b3

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

javascript/ql/lib/semmle/javascript/dataflow/Configuration.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -947,7 +947,7 @@ private predicate exploratoryFlowStep(
947947
isAdditionalLoadStoreStep(pred, succ, _, _, cfg) or
948948
// the following three disjuncts taken together over-approximate flow through
949949
// higher-order calls
950-
callback(pred, succ) or
950+
exploratoryCallbackStep(pred, succ) or
951951
succ = pred.(DataFlow::FunctionNode).getAParameter() or
952952
exploratoryBoundInvokeStep(pred, succ)
953953
}

javascript/ql/lib/semmle/javascript/dataflow/TrackedNodes.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -154,7 +154,7 @@ private module NodeTracking {
154154
or
155155
basicLoadStep(mid, nd, _)
156156
or
157-
callback(mid, nd)
157+
exploratoryCallbackStep(mid, nd)
158158
or
159159
nd = mid.(DataFlow::FunctionNode).getAParameter()
160160
)

javascript/ql/lib/semmle/javascript/dataflow/internal/FlowSteps.qll

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -434,7 +434,7 @@ private module CachedSteps {
434434
* invocation.
435435
*/
436436
cached
437-
predicate callback(DataFlow::Node arg, DataFlow::SourceNode cb) {
437+
predicate exploratoryCallbackStep(DataFlow::Node arg, DataFlow::SourceNode cb) {
438438
Stages::TypeTracking::ref() and
439439
exists(DataFlow::InvokeNode invk, DataFlow::ParameterNode cbParm, DataFlow::Node cbArg |
440440
arg = invk.getAnArgument() and
@@ -444,7 +444,7 @@ private module CachedSteps {
444444
)
445445
or
446446
exists(DataFlow::ParameterNode cbParm, DataFlow::Node cbArg |
447-
callback(arg, cbParm) and
447+
exploratoryCallbackStep(arg, cbParm) and
448448
callStep(cbArg, cbParm) and
449449
cb.flowsTo(cbArg)
450450
)

0 commit comments

Comments
 (0)