Skip to content

Commit cee0614

Browse files
committed
C#: Deprecate ModelCsv classes.
1 parent 990a898 commit cee0614

File tree

1 file changed

+26
-10
lines changed

1 file changed

+26
-10
lines changed

csharp/ql/lib/semmle/code/csharp/dataflow/ExternalFlow.qll

Lines changed: 26 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -128,53 +128,69 @@ private module Frameworks {
128128
}
129129

130130
/**
131+
* DEPRECATED: Define source models as data extensions instead.
132+
*
131133
* A unit class for adding additional source model rows.
132134
*
133135
* Extend this class to add additional source definitions.
134136
*/
135-
class SourceModelCsv extends Unit {
137+
deprecated class SourceModelCsv = SourceModelCsvInternal;
138+
139+
private class SourceModelCsvInternal extends Unit {
136140
/** Holds if `row` specifies a source definition. */
137141
abstract predicate row(string row);
138142
}
139143

140144
/**
145+
* DEPRECATED: Define sink models as data extensions instead.
146+
*
141147
* A unit class for adding additional sink model rows.
142148
*
143149
* Extend this class to add additional sink definitions.
144150
*/
145-
class SinkModelCsv extends Unit {
151+
deprecated class SinkModelCsv = SinkModelCsvInternal;
152+
153+
private class SinkModelCsvInternal extends Unit {
146154
/** Holds if `row` specifies a sink definition. */
147155
abstract predicate row(string row);
148156
}
149157

150158
/**
159+
* DEPRECATED: Define summary models as data extensions instead.
160+
*
151161
* A unit class for adding additional summary model rows.
152162
*
153163
* Extend this class to add additional flow summary definitions.
154164
*/
155-
class SummaryModelCsv extends Unit {
165+
deprecated class SummaryModelCsv = SummaryModelCsvInternal;
166+
167+
private class SummaryModelCsvInternal extends Unit {
156168
/** Holds if `row` specifies a summary definition. */
157169
abstract predicate row(string row);
158170
}
159171

160172
/**
161-
* A unit class for adding negative summary model rows.
173+
* DEPRECATED: Define negative summary models as data extensions instead.
162174
*
163-
* Extend this class to add additional flow summary definitions.
175+
* A unit class for adding additional negative summary model rows.
176+
*
177+
* Extend this class to add additional negative summary definitions.
164178
*/
165-
class NegativeSummaryModelCsv extends Unit {
179+
deprecated class NegativeSummaryModelCsv = NegativeSummaryModelCsvInternal;
180+
181+
private class NegativeSummaryModelCsvInternal extends Unit {
166182
/** Holds if `row` specifies a negative summary definition. */
167183
abstract predicate row(string row);
168184
}
169185

170-
private predicate sourceModelInternal(string row) { any(SourceModelCsv s).row(row) }
186+
private predicate sourceModelInternal(string row) { any(SourceModelCsvInternal s).row(row) }
171187

172-
private predicate summaryModelInternal(string row) { any(SummaryModelCsv s).row(row) }
188+
private predicate summaryModelInternal(string row) { any(SummaryModelCsvInternal s).row(row) }
173189

174-
private predicate sinkModelInternal(string row) { any(SinkModelCsv s).row(row) }
190+
private predicate sinkModelInternal(string row) { any(SinkModelCsvInternal s).row(row) }
175191

176192
private predicate negativeSummaryModelInternal(string row) {
177-
any(NegativeSummaryModelCsv s).row(row)
193+
any(NegativeSummaryModelCsvInternal s).row(row)
178194
}
179195

180196
/**

0 commit comments

Comments
 (0)