Skip to content

Commit d1fe62d

Browse files
committed
(Minor) Update comments to match ExternalFlow docs
1 parent 1ae9d68 commit d1fe62d

File tree

5 files changed

+6
-6
lines changed

5 files changed

+6
-6
lines changed

java/ql/src/semmle/code/java/frameworks/guava/Base.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ private class GuavaBaseCsv extends SummaryModelCsv {
77
override predicate row(string row) {
88
row =
99
[
10-
//"package;type;overrides;name;signature;ext;inputspec;outputspec;kind",
10+
//`namespace; type; subtypes; name; signature; ext; input; output; kind`
1111
"com.google.common.base;Strings;false;emptyToNull;(String);;Argument[0];ReturnValue;value",
1212
"com.google.common.base;Strings;false;nullToEmpty;(String);;Argument[0];ReturnValue;value",
1313
"com.google.common.base;Strings;false;padStart;(String,int,char);;Argument[0];ReturnValue;taint",

java/ql/src/semmle/code/java/frameworks/guava/IO.qll

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ private class GuavaIoCsv extends SummaryModelCsv {
77
override predicate row(string row) {
88
row =
99
[
10-
//"package;type;overrides;name;signature;ext;inputspec;outputspec;kind",
10+
//`namespace; type; subtypes; name; signature; ext; input; output; kind`
1111
"com.google.common.io;BaseEncoding;true;decode;(CharSequence);;Argument[0];ReturnValue;taint",
1212
"com.google.common.io;BaseEncoding;true;decodingStream;(Reader);;Argument[0];ReturnValue;taint",
1313
"com.google.common.io;BaseEncoding;true;decodingSource;(CharSource);;Argument[0];ReturnValue;taint",
@@ -89,7 +89,7 @@ private class GuavaIoSinkCsv extends SinkModelCsv {
8989
override predicate row(string row) {
9090
row =
9191
[
92-
//"package;type;overrides;name;signature;ext;inputspec;kind",
92+
//`namespace; type; subtypes; name; signature; ext; input; kind`
9393
"com.google.common.io;Resources;false;asByteSource;(URL);;Argument[0];url-open-stream",
9494
"com.google.common.io;Resources;false;asCharSource;(URL,Charset);;Argument[0];url-open-stream",
9595
"com.google.common.io;Resources;false;copy;(URL,OutputStream);;Argument[0];url-open-stream",

java/ql/test/library-tests/dataflow/external-models/sinks.ql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ class SinkModelTest extends SinkModelCsv {
77
override predicate row(string row) {
88
row =
99
[
10-
//"package;type;overrides;name;signature;ext;spec;kind",
10+
//`namespace; type; subtypes; name; signature; ext; input; kind`
1111
"my.qltest;B;false;sink1;(Object);;Argument[0];qltest",
1212
"my.qltest;B;false;sinkMethod;();;ReturnValue;qltest",
1313
"my.qltest;B$Tag;false;;;Annotated;ReturnValue;qltest-retval",

java/ql/test/library-tests/dataflow/external-models/srcs.ql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ class SourceModelTest extends SourceModelCsv {
77
override predicate row(string row) {
88
row =
99
[
10-
//"package;type;overrides;name;signature;ext;spec;kind",
10+
//`namespace; type; subtypes; name; signature; ext; output; kind`
1111
"my.qltest;A;false;src1;();;ReturnValue;qltest",
1212
"my.qltest;A;false;src1;(String);;ReturnValue;qltest",
1313
"my.qltest;A;false;src1;(java.lang.String);;ReturnValue;qltest-alt",

java/ql/test/library-tests/dataflow/external-models/steps.ql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ class SummaryModelTest extends SummaryModelCsv {
88
override predicate row(string row) {
99
row =
1010
[
11-
//"package;type;overrides;name;signature;ext;inputspec;outputspec;kind",
11+
//`namespace; type; subtypes; name; signature; ext; input; output; kind`
1212
"my.qltest;C;false;stepArgRes;(Object);;Argument[0];ReturnValue;taint",
1313
"my.qltest;C;false;stepArgArg;(Object,Object);;Argument[0];Argument[1];taint",
1414
"my.qltest;C;false;stepArgQual;(Object);;Argument[0];Argument[-1];taint",

0 commit comments

Comments
 (0)