Skip to content

Commit d5895c1

Browse files
committed
Python: Changing signature in overriden method is not an error
Rather, fulfiling the Liskov substitution principle is an opinionated recommendation. Looking at `py/inheritance/incorrect-overridden-signature` and `py/mixed-tuple-returns`, it seems very appropriate that this should have `@severity recommendation`, and `@sub-severity high`.
1 parent 287bc40 commit d5895c1

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

python/ql/src/Functions/IncorrectlySpecifiedOverriddenMethod.ql

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@
44
* the arguments with which it is called, and if it were called, would be likely to cause an error.
55
* @kind problem
66
* @tags maintainability
7-
* @problem.severity error
8-
* @sub-severity low
7+
* @problem.severity recommendation
8+
* @sub-severity high
99
* @precision high
1010
* @id py/inheritance/incorrect-overridden-signature
1111
*/

0 commit comments

Comments
 (0)