Skip to content

Commit d6e9b07

Browse files
committed
Add JBoss BasicLogger and SciJava Logger
1 parent 6d329bc commit d6e9b07

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

java/ql/src/experimental/CWE-532/SensitiveInfoLog.ql

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,10 +31,12 @@ class CredentialExpr extends Expr {
3131
class LoggerType extends RefType {
3232
LoggerType() {
3333
this.hasQualifiedName("org.apache.log4j", "Category") or //Log4J
34-
this.hasQualifiedName("org.apache.logging.log4j", "Logger") or //Log4j 2
34+
this.hasQualifiedName("org.apache.logging.log4j", "Logger") or //Log4J 2
3535
this.hasQualifiedName("org.slf4j", "Logger") or //SLF4j and Gradle Logging
36-
this.hasQualifiedName("org.jboss.logging", "Logger") or //JBoss Logging
37-
this.hasQualifiedName("org.apache.commons.logging", "Log") //Apache Commons Logging
36+
this.hasQualifiedName("org.jboss.logging", "BasicLogger") or //JBoss Logging
37+
this.hasQualifiedName("org.jboss.logging", "Logger") or //JBoss Logging (`org.jboss.logging.Logger` in some implementations like JBoss Application Server 4.0.4 did not implement `BasicLogger`)
38+
this.hasQualifiedName("org.apache.commons.logging", "Log") or //Apache Commons Logging
39+
this.hasQualifiedName("org.scijava.log", "Logger") //SciJava Logging
3840
}
3941
}
4042

0 commit comments

Comments
 (0)