C#: Fix bug in BaseSSA::reachesEndOf/3

hvitved · hvitved · commit d8792f2f7f10 · 2021-02-23T14:06:27.000+01:00
diff --git a/csharp/ql/src/semmle/code/csharp/dataflow/internal/BaseSSA.qll b/csharp/ql/src/semmle/code/csharp/dataflow/internal/BaseSSA.qll
@@ -101,7 +101,7 @@ module BaseSsa {
     or
     exists(BasicBlock mid |
       reachesEndOf(def, v, mid) and
-      not exists(ssaRefRank(mid, _, v, SsaDef())) and
+      not exists(ssaRefRank(bb, _, v, SsaDef())) and
       bb = mid.getASuccessor()
     )
   }

Original file line number	Diff line number	Diff line change
`@@ -101,7 +101,7 @@ module BaseSsa {`
`101`	`101`	`or`
`102`	`102`	`exists(BasicBlock mid \|`
`103`	`103`	`reachesEndOf(def, v, mid) and`
`104`		`- not exists(ssaRefRank(mid, _, v, SsaDef())) and`
	`104`	`+ not exists(ssaRefRank(bb, _, v, SsaDef())) and`
`105`	`105`	`bb = mid.getASuccessor()`
`106`	`106`	`)`
`107`	`107`	`}`