Apply suggestions from code review

asgerf · erik-krogh · web-flow · commit d8927e56123f · 2021-07-12T14:23:58.000+02:00
Co-authored-by: Erik Krogh Kristensen &lt;erik-krogh@github.com&gt;
diff --git a/javascript/ql/test/library-tests/TaintTracking/capture-flow.js b/javascript/ql/test/library-tests/TaintTracking/capture-flow.js
@@ -16,7 +16,7 @@ function outerMost() {
     return outer();
 }
 
-sink(outerMost()); // NOT OK - but missed
+sink(outerMost()); // NOT OK
 
 function confuse(x) {
     let captured;
@@ -27,5 +27,5 @@ function confuse(x) {
     return captured;
 }
 
-sink(confuse('safe')); // OK - but incorrectly flagged
+sink(confuse('safe')); // OK
 sink(confuse(source())); // NOT OK

Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,7 @@ function outerMost() {`
`16`	`16`	`return outer();`
`17`	`17`	`}`
`18`	`18`
`19`		`-sink(outerMost()); // NOT OK - but missed`
	`19`	`+sink(outerMost()); // NOT OK`
`20`	`20`
`21`	`21`	`function confuse(x) {`
`22`	`22`	`let captured;`
`@@ -27,5 +27,5 @@ function confuse(x) {`
`27`	`27`	`return captured;`
`28`	`28`	`}`
`29`	`29`
`30`		`-sink(confuse('safe')); // OK - but incorrectly flagged`
	`30`	`+sink(confuse('safe')); // OK`
`31`	`31`	`sink(confuse(source())); // NOT OK`