Skip to content

Commit d8f32e3

Browse files
author
Dave Bartolomeo
authored
Merge pull request github#3392 from rdmarsh2/rdmarsh/cpp/qldoc-get-ConvertedResultExpression
C++/C#: improve qldoc on IR get*ResultExpression
2 parents c66ec3c + 83e222e commit d8f32e3

File tree

5 files changed

+15
-10
lines changed

5 files changed

+15
-10
lines changed

cpp/ql/src/semmle/code/cpp/ir/implementation/aliased_ssa/Instruction.qll

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -190,14 +190,15 @@ class Instruction extends Construction::TInstruction {
190190
final Language::Location getLocation() { result = getAST().getLocation() }
191191

192192
/**
193-
* Gets the `Expr` whose result is computed by this instruction, if any.
193+
* Gets the `Expr` whose result is computed by this instruction, if any. The `Expr` may be a
194+
* conversion.
194195
*/
195196
final Language::Expr getConvertedResultExpression() {
196197
result = Construction::getInstructionConvertedResultExpression(this)
197198
}
198199

199200
/**
200-
* Gets the unconverted `Expr` whose result is computed by this instruction, if any.
201+
* Gets the unconverted form of the `Expr` whose result is computed by this instruction, if any.
201202
*/
202203
final Language::Expr getUnconvertedResultExpression() {
203204
result = Construction::getInstructionUnconvertedResultExpression(this)

cpp/ql/src/semmle/code/cpp/ir/implementation/raw/Instruction.qll

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -190,14 +190,15 @@ class Instruction extends Construction::TInstruction {
190190
final Language::Location getLocation() { result = getAST().getLocation() }
191191

192192
/**
193-
* Gets the `Expr` whose result is computed by this instruction, if any.
193+
* Gets the `Expr` whose result is computed by this instruction, if any. The `Expr` may be a
194+
* conversion.
194195
*/
195196
final Language::Expr getConvertedResultExpression() {
196197
result = Construction::getInstructionConvertedResultExpression(this)
197198
}
198199

199200
/**
200-
* Gets the unconverted `Expr` whose result is computed by this instruction, if any.
201+
* Gets the unconverted form of the `Expr` whose result is computed by this instruction, if any.
201202
*/
202203
final Language::Expr getUnconvertedResultExpression() {
203204
result = Construction::getInstructionUnconvertedResultExpression(this)

cpp/ql/src/semmle/code/cpp/ir/implementation/unaliased_ssa/Instruction.qll

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -190,14 +190,15 @@ class Instruction extends Construction::TInstruction {
190190
final Language::Location getLocation() { result = getAST().getLocation() }
191191

192192
/**
193-
* Gets the `Expr` whose result is computed by this instruction, if any.
193+
* Gets the `Expr` whose result is computed by this instruction, if any. The `Expr` may be a
194+
* conversion.
194195
*/
195196
final Language::Expr getConvertedResultExpression() {
196197
result = Construction::getInstructionConvertedResultExpression(this)
197198
}
198199

199200
/**
200-
* Gets the unconverted `Expr` whose result is computed by this instruction, if any.
201+
* Gets the unconverted form of the `Expr` whose result is computed by this instruction, if any.
201202
*/
202203
final Language::Expr getUnconvertedResultExpression() {
203204
result = Construction::getInstructionUnconvertedResultExpression(this)

csharp/ql/src/semmle/code/csharp/ir/implementation/raw/Instruction.qll

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -190,14 +190,15 @@ class Instruction extends Construction::TInstruction {
190190
final Language::Location getLocation() { result = getAST().getLocation() }
191191

192192
/**
193-
* Gets the `Expr` whose result is computed by this instruction, if any.
193+
* Gets the `Expr` whose result is computed by this instruction, if any. The `Expr` may be a
194+
* conversion.
194195
*/
195196
final Language::Expr getConvertedResultExpression() {
196197
result = Construction::getInstructionConvertedResultExpression(this)
197198
}
198199

199200
/**
200-
* Gets the unconverted `Expr` whose result is computed by this instruction, if any.
201+
* Gets the unconverted form of the `Expr` whose result is computed by this instruction, if any.
201202
*/
202203
final Language::Expr getUnconvertedResultExpression() {
203204
result = Construction::getInstructionUnconvertedResultExpression(this)

csharp/ql/src/semmle/code/csharp/ir/implementation/unaliased_ssa/Instruction.qll

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -190,14 +190,15 @@ class Instruction extends Construction::TInstruction {
190190
final Language::Location getLocation() { result = getAST().getLocation() }
191191

192192
/**
193-
* Gets the `Expr` whose result is computed by this instruction, if any.
193+
* Gets the `Expr` whose result is computed by this instruction, if any. The `Expr` may be a
194+
* conversion.
194195
*/
195196
final Language::Expr getConvertedResultExpression() {
196197
result = Construction::getInstructionConvertedResultExpression(this)
197198
}
198199

199200
/**
200-
* Gets the unconverted `Expr` whose result is computed by this instruction, if any.
201+
* Gets the unconverted form of the `Expr` whose result is computed by this instruction, if any.
201202
*/
202203
final Language::Expr getUnconvertedResultExpression() {
203204
result = Construction::getInstructionUnconvertedResultExpression(this)

0 commit comments

Comments
 (0)