C++: Improvement in Synchronization.qll.

geoffw0 · geoffw0 · commit de25bc6c7873 · 2020-06-30T12:14:56.000+01:00
diff --git a/cpp/ql/src/semmle/code/cpp/commons/Synchronization.qll b/cpp/ql/src/semmle/code/cpp/commons/Synchronization.qll
@@ -169,7 +169,10 @@ class DefaultMutexType extends MutexType {
   }
 }
 
-/** Holds if `arg` is the mutex argument of a call to lock or unlock. */
+/**
+ * Holds if `arg` is the mutex argument of a call to lock or unlock and
+ * `argType` is the type of the mutex.
+ */
 private predicate lockArg(Expr arg, MutexType argType, FunctionCall call) {
   argType = arg.getUnderlyingType().stripType() and
   (

Original file line number	Diff line number	Diff line change
`@@ -169,7 +169,10 @@ class DefaultMutexType extends MutexType {`
`169`	`169`	`}`
`170`	`170`	`}`
`171`	`171`
`172`		-/** Holds if `arg` is the mutex argument of a call to lock or unlock. */
	`172`	`+/**`
	`173`	+ * Holds if `arg` is the mutex argument of a call to lock or unlock and
	`174`	+ * `argType` is the type of the mutex.
	`175`	`+ */`
`173`	`176`	`private predicate lockArg(Expr arg, MutexType argType, FunctionCall call) {`
`174`	`177`	`argType = arg.getUnderlyingType().stripType() and`
`175`	`178`	`(`