JS: Make PropRef.getBase non-recursive

asgerf · asgerf · commit de879c070709 · 2021-03-24T12:57:16.000Z
diff --git a/javascript/ql/src/semmle/javascript/dataflow/DataFlow.qll b/javascript/ql/src/semmle/javascript/dataflow/DataFlow.qll
@@ -724,7 +724,7 @@ module DataFlow {
     override ParameterField prop;
 
     override Node getBase() {
-      result = thisNode(prop.getDeclaringClass().getConstructor().getBody())
+      thisNode(result, prop.getDeclaringClass().getConstructor().getBody())
     }
 
     override Expr getPropertyNameExpr() {
@@ -758,7 +758,7 @@ module DataFlow {
     }
 
     override Node getBase() {
-      result = thisNode(prop.getDeclaringClass().getConstructor().getBody())
+      thisNode(result, prop.getDeclaringClass().getConstructor().getBody())
     }
 
     override Expr getPropertyNameExpr() { result = prop.getNameExpr() }

Original file line number	Diff line number	Diff line change
`@@ -724,7 +724,7 @@ module DataFlow {`
`724`	`724`	`override ParameterField prop;`
`725`	`725`
`726`	`726`	`override Node getBase() {`
`727`		`- result = thisNode(prop.getDeclaringClass().getConstructor().getBody())`
	`727`	`+ thisNode(result, prop.getDeclaringClass().getConstructor().getBody())`
`728`	`728`	`}`
`729`	`729`
`730`	`730`	`override Expr getPropertyNameExpr() {`
`@@ -758,7 +758,7 @@ module DataFlow {`
`758`	`758`	`}`
`759`	`759`
`760`	`760`	`override Node getBase() {`
`761`		`- result = thisNode(prop.getDeclaringClass().getConstructor().getBody())`
	`761`	`+ thisNode(result, prop.getDeclaringClass().getConstructor().getBody())`
`762`	`762`	`}`
`763`	`763`
`764`	`764`	`override Expr getPropertyNameExpr() { result = prop.getNameExpr() }`