Skip to content

Commit e0bcfe2

Browse files
committed
add failing test
1 parent c95a6ea commit e0bcfe2

File tree

2 files changed

+11
-0
lines changed

2 files changed

+11
-0
lines changed

javascript/ql/test/query-tests/Security/CWE-312/CleartextLogging.expected

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -133,6 +133,9 @@ nodes
133133
| passwords.js:170:11:170:18 | password |
134134
| passwords.js:170:11:170:39 | passwor ... g, "*") |
135135
| passwords.js:170:11:170:39 | passwor ... g, "*") |
136+
| passwords.js:173:17:173:26 | myPassword |
137+
| passwords.js:173:17:173:26 | myPassword |
138+
| passwords.js:173:17:173:26 | myPassword |
136139
| passwords_in_browser1.js:2:13:2:20 | password |
137140
| passwords_in_browser1.js:2:13:2:20 | password |
138141
| passwords_in_browser1.js:2:13:2:20 | password |
@@ -277,6 +280,7 @@ edges
277280
| passwords.js:170:11:170:18 | password | passwords.js:170:11:170:39 | passwor ... g, "*") |
278281
| passwords.js:170:11:170:18 | password | passwords.js:170:11:170:39 | passwor ... g, "*") |
279282
| passwords.js:170:11:170:18 | password | passwords.js:170:11:170:39 | passwor ... g, "*") |
283+
| passwords.js:173:17:173:26 | myPassword | passwords.js:173:17:173:26 | myPassword |
280284
| passwords_in_browser1.js:2:13:2:20 | password | passwords_in_browser1.js:2:13:2:20 | password |
281285
| passwords_in_browser2.js:2:13:2:20 | password | passwords_in_browser2.js:2:13:2:20 | password |
282286
| passwords_in_server_1.js:6:13:6:20 | password | passwords_in_server_1.js:6:13:6:20 | password |
@@ -322,6 +326,7 @@ edges
322326
| passwords.js:164:14:164:42 | passwor ... g, "*") | passwords.js:164:14:164:21 | password | passwords.js:164:14:164:42 | passwor ... g, "*") | This logs sensitive data returned by $@ as clear text. | passwords.js:164:14:164:21 | password | an access to password |
323327
| passwords.js:169:17:169:45 | passwor ... g, "*") | passwords.js:169:17:169:24 | password | passwords.js:169:17:169:45 | passwor ... g, "*") | This logs sensitive data returned by $@ as clear text. | passwords.js:169:17:169:24 | password | an access to password |
324328
| passwords.js:170:11:170:39 | passwor ... g, "*") | passwords.js:170:11:170:18 | password | passwords.js:170:11:170:39 | passwor ... g, "*") | This logs sensitive data returned by $@ as clear text. | passwords.js:170:11:170:18 | password | an access to password |
329+
| passwords.js:173:17:173:26 | myPassword | passwords.js:173:17:173:26 | myPassword | passwords.js:173:17:173:26 | myPassword | This logs sensitive data returned by $@ as clear text. | passwords.js:173:17:173:26 | myPassword | an access to myPassword |
325330
| passwords_in_server_1.js:6:13:6:20 | password | passwords_in_server_1.js:6:13:6:20 | password | passwords_in_server_1.js:6:13:6:20 | password | This logs sensitive data returned by $@ as clear text. | passwords_in_server_1.js:6:13:6:20 | password | an access to password |
326331
| passwords_in_server_2.js:3:13:3:20 | password | passwords_in_server_2.js:3:13:3:20 | password | passwords_in_server_2.js:3:13:3:20 | password | This logs sensitive data returned by $@ as clear text. | passwords_in_server_2.js:3:13:3:20 | password | an access to password |
327332
| passwords_in_server_3.js:2:13:2:20 | password | passwords_in_server_3.js:2:13:2:20 | password | passwords_in_server_3.js:2:13:2:20 | password | This logs sensitive data returned by $@ as clear text. | passwords_in_server_3.js:2:13:2:20 | password | an access to password |

javascript/ql/test/query-tests/Security/CWE-312/passwords.js

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -168,4 +168,10 @@ const debug = require('debug')('test');
168168
(function () {
169169
console.log(password.replace(/foo/g, "*")); // NOT OK
170170
debug(password.replace(/foo/g, "*")); // NOT OK
171+
172+
const myPassword = foo();
173+
console.log(myPassword); // NOT OK
174+
175+
const myPasscode = foo();
176+
console.log(myPasscode); // NOT OK - but not flagged
171177
});

0 commit comments

Comments
 (0)