Merge pull request github#5218 from MathiasVP/no-write-side-effects-for-const-pointer-params

C++: Don't generate write side effects for const parameter indirections

Author: jbj

cpp/ql/src/semmle/code/cpp/ir/implementation/raw/internal/TranslatedElement.qll

@@ -658,14 +658,18 @@ newtype TTranslatedElement =
         t instanceof ReferenceType
       ) and
       (
-        isWrite = true or
+        isWrite = true and
+        not call.getTarget().getParameter(n).getType().isDeeplyConstBelow()
+        or
         isWrite = false
       )
       or
       not call.getTarget() instanceof SideEffectFunction and
       n = -1 and
       (
-        isWrite = true or
+        isWrite = true and
+        not call.getTarget() instanceof ConstMemberFunction
+        or
         isWrite = false
       )
     ) and