Avoid bad join order

owen-mc · owen-mc · commit e448dcb72564 · 2021-04-22T09:30:49.000+01:00
We want to avoid joining on `i` first.
diff --git a/java/ql/src/semmle/code/java/security/ExternalProcess.qll b/java/ql/src/semmle/code/java/security/ExternalProcess.qll
@@ -18,7 +18,7 @@ abstract class ExecCallable extends Callable {
 class ArgumentToExec extends Expr {
   ArgumentToExec() {
     exists(Call execCall, ExecCallable execCallable, int i |
-      execCall.getArgument(i) = this and
+      execCall.getArgument(pragma[only_bind_into](i)) = this and
       execCallable = execCall.getCallee() and
       i = execCallable.getAnExecutedArgument()
     )

Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,7 @@ abstract class ExecCallable extends Callable {`
`18`	`18`	`class ArgumentToExec extends Expr {`
`19`	`19`	`ArgumentToExec() {`
`20`	`20`	`exists(Call execCall, ExecCallable execCallable, int i \|`
`21`		`- execCall.getArgument(i) = this and`
	`21`	`+ execCall.getArgument(pragma[only_bind_into](i)) = this and`
`22`	`22`	`execCallable = execCall.getCallee() and`
`23`	`23`	`i = execCallable.getAnExecutedArgument()`
`24`	`24`	`)`