Python: Apply suggestions from code review

Co-authored-by: Rasmus Wriedt Larsen <[email protected]>

Author: tausbn

python/ql/src/semmle/python/ApiGraphs.qll

@@ -449,7 +449,7 @@ module API {
       name = n.getId() and
       // Not already defined in an enclosing scope.
       not exists(LocalVariable v |
-        v.getId() = name and v.getScope().getEnclosingScope*() = n.getScope()
+        v.getId() = name and v.getScope() = n.getScope().getEnclosingScope*()
       ) and
       not name = getBuiltInName() and
       s = n.getScope().getEnclosingScope*() and

python/ql/test/experimental/dataflow/ApiGraphs/test_import_star.py

@@ -6,6 +6,8 @@
 # going into it from its corresponding `GlobalSsaVariable`.
 hello() #$ MISSING: use=moduleImport("unknown").getMember("hello").getReturn()
 
+# We don't want our analysis to think that either `non_module_member` or `outer_bar` can
+# come from `from unknown import *`
 non_module_member
 
 outer_bar = 5