Skip to content

Commit e66b555

Browse files
authored
Merge pull request github#5924 from MathiasVP/cleanup-modelFlow
C++: Remove a disjunction from `modelFlow`
2 parents 99833f1 + 4d00513 commit e66b555

File tree

1 file changed

+1
-7
lines changed

1 file changed

+1
-7
lines changed

cpp/ql/src/semmle/code/cpp/ir/dataflow/internal/DataFlowUtil.qll

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -748,16 +748,10 @@ private predicate modelFlow(Operand opFrom, Instruction iTo) {
748748
)
749749
or
750750
exists(int index, ReadSideEffectInstruction read |
751-
modelIn.isParameterDeref(index) and
751+
modelIn.isParameterDerefOrQualifierObject(index) and
752752
read = getSideEffectFor(call, index) and
753753
opFrom = read.getSideEffectOperand()
754754
)
755-
or
756-
exists(ReadSideEffectInstruction read |
757-
modelIn.isQualifierObject() and
758-
read = getSideEffectFor(call, -1) and
759-
opFrom = read.getSideEffectOperand()
760-
)
761755
)
762756
)
763757
}

0 commit comments

Comments
 (0)