Skip to content

Commit e8e27e0

Browse files
committed
C#: Address review comments
1 parent 3d37a49 commit e8e27e0

File tree

2 files changed

+3
-5
lines changed

2 files changed

+3
-5
lines changed

csharp/ql/src/semmle/code/csharp/Generics.qll

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -87,8 +87,6 @@ class UnboundGenericType extends ValueOrRefType, UnboundGeneric {
8787
* is distinct from the `G<T>` used in the class definition, since in `G<T> g;`
8888
* the `T` will be the actual type parameter used for the `Other` that contains
8989
* `g`, whereas in `class G<T> { ... }` the `T` is a formal type parameter of `G`.
90-
*
91-
* It is important not to get confused by the superficial syntactic similarity.
9290
*/
9391
override ConstructedType getAConstructedGeneric() {
9492
result = UnboundGeneric.super.getAConstructedGeneric()
@@ -354,11 +352,9 @@ class UnboundGenericDelegateType extends DelegateType, UnboundGenericType {
354352
* arguments have been supplied, for example `G<int>` or the `G<T>` in
355353
* `class Other<T> { G<T> g; }`. Constructed types can be divided further into
356354
* those that are open (for example `G1<T>` or `G2<T,T,U,int>`), in the sense
357-
* that one or more of their type argumentsis a type parameter, versus those
355+
* that one or more of their type arguments is a type parameter, versus those
358356
* that are closed (for example `G1<int>` or `G2<long,long,float,int>`).
359357
*
360-
* We do not currently distinguish the two in this library.
361-
*
362358
* Either a constructed `struct` (`ConstructedStruct`), constructed `class`
363359
* (`ConstructedClass`), constructed `interface` (`ConstructedInterface`),
364360
* or constructed method (`ConstructedMethod`).
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,4 @@
11
description: Removed relations `is_constructed` and `is_generic`
22
compatibility: full
3+
is_generic.rel: delete
4+
is_constructed.rel: delete

0 commit comments

Comments
 (0)