Support field access data flow for JacksonDeserializedTaintStep

JLLeitschuh · JLLeitschuh · commit e97bad3b3395 · 2021-05-11T10:36:47.000-04:00
diff --git a/java/ql/src/semmle/code/java/frameworks/jackson/JacksonSerializability.qll b/java/ql/src/semmle/code/java/frameworks/jackson/JacksonSerializability.qll
@@ -167,7 +167,7 @@ class JacksonDeserializableFieldAccess extends FieldAccess {
  */
 class JacksonDeserializedTaintStep extends AdditionalTaintStep {
   override predicate step(DataFlow::Node node1, DataFlow::Node node2) {
-    node2.asExpr().(JacksonDeserializableFieldAccess).getQualifier() = node1.asExpr()
+    DataFlow::getFieldQualifier(node2.asExpr().(JacksonDeserializableFieldAccess)) = node1
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -167,7 +167,7 @@ class JacksonDeserializableFieldAccess extends FieldAccess {`
`167`	`167`	`*/`
`168`	`168`	`class JacksonDeserializedTaintStep extends AdditionalTaintStep {`
`169`	`169`	`override predicate step(DataFlow::Node node1, DataFlow::Node node2) {`
`170`		`- node2.asExpr().(JacksonDeserializableFieldAccess).getQualifier() = node1.asExpr()`
	`170`	`+ DataFlow::getFieldQualifier(node2.asExpr().(JacksonDeserializableFieldAccess)) = node1`
`171`	`171`	`}`
`172`	`172`	`}`
`173`	`173`