Skip to content

Commit ec38df6

Browse files
committed
update consistency comments for CWE-918
1 parent c5285f7 commit ec38df6

File tree

1 file changed

+3
-3
lines changed
  • javascript/ql/test/query-tests/Security/CWE-918

1 file changed

+3
-3
lines changed

javascript/ql/test/query-tests/Security/CWE-918/tst.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,8 @@ var server = http.createServer(function(req, res) {
2020
request.get(tainted); // NOT OK
2121

2222
var options = {};
23-
options.url = tainted;
24-
request(options); // NOT OK
23+
options.url = tainted; // NOT OK
24+
request(options);
2525

2626
request("http://" + tainted); // NOT OK
2727

@@ -44,7 +44,7 @@ var server = http.createServer(function(req, res) {
4444

4545
request('http://example.com/' + base + '/' + tainted); // NOT OK
4646

47-
request('http://example.com/' + base + ('/' + tainted)); // NOT OK - but not flagged
47+
request('http://example.com/' + base + ('/' + tainted)); // NOT OK - but not flagged [INCONSISTENCY]
4848

4949
request(`http://example.com/?${base}/${tainted}`); // OK
5050

0 commit comments

Comments
 (0)