Skip to content

Commit ed1d855

Browse files
author
Sauyon Lee
committed
Java: Remove redundant models from Spring web.util and fix typo
1 parent 9c1d5a7 commit ed1d855

File tree

1 file changed

+2
-38
lines changed

1 file changed

+2
-38
lines changed

‎java/ql/src/semmle/code/java/frameworks/spring/SpringWebUtil.qll

Lines changed: 2 additions & 38 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ private class FlowSummaries extends SummaryModelCsv {
2929
"org.springframework.web.util;UriBuilder;true;queryParamIfPresent;;;Argument[0];Argument[-1];taint",
3030
"org.springframework.web.util;UriBuilder;true;queryParamIfPresent;;;Element of Argument[1];Argument[-1];taint",
3131
"org.springframework.web.util;UriBuilder;true;queryParams;;;Argument[-1];ReturnValue;value",
32-
"org.springframework.web.util;UriBuilder;true;queryParams;;;MapKey of Argument[0];SyntheticField[uri.Query] ofArgument[-1];taint",
32+
"org.springframework.web.util;UriBuilder;true;queryParams;;;MapKey of Argument[0];Argument[-1];taint",
3333
"org.springframework.web.util;UriBuilder;true;queryParams;;;Element of MapValue of Argument[0];Argument[-1];taint",
3434
"org.springframework.web.util;UriBuilder;true;replacePath;;;Argument[-1];ReturnValue;value",
3535
"org.springframework.web.util;UriBuilder;true;replacePath;;;Argument[0];Argument[-1];taint",
@@ -40,6 +40,7 @@ private class FlowSummaries extends SummaryModelCsv {
4040
"org.springframework.web.util;UriBuilder;true;replaceQueryParam;(String,Collection);;Element of Argument[1];Argument[-1];taint",
4141
"org.springframework.web.util;UriBuilder;true;replaceQueryParam;(String,Object[]);;ArrayElement of Argument[1];Argument[-1];taint",
4242
"org.springframework.web.util;UriBuilder;true;replaceQueryParams;;;Argument[-1];ReturnValue;value",
43+
"org.springframework.web.util;UriBuilder;true;replaceQueryParams;;;MapKey of Argument[0];Argument[-1];taint",
4344
"org.springframework.web.util;UriBuilder;true;replaceQueryParams;;;Element of MapValue of Argument[0];Argument[-1];taint",
4445
"org.springframework.web.util;UriBuilder;true;scheme;;;Argument[-1];ReturnValue;value",
4546
"org.springframework.web.util;UriBuilder;true;scheme;;;Argument[0];Argument[-1];taint",
@@ -103,48 +104,13 @@ private class FlowSummaries extends SummaryModelCsv {
103104
"org.springframework.web.util;UriComponentsBuilder;false;buildAndExpand;(Object[]);;ArrayElement of Argument[0];ReturnValue;taint",
104105
"org.springframework.web.util;UriComponentsBuilder;false;cloneBuilder;;;Argument[-1];ReturnValue;value",
105106
"org.springframework.web.util;UriComponentsBuilder;false;encode;;;Argument[-1];ReturnValue;value",
106-
"org.springframework.web.util;UriComponentsBuilder;false;fragment;;;Argument[-1];ReturnValue;value",
107-
"org.springframework.web.util;UriComponentsBuilder;false;fragment;;;Argument[0];Argument[-1];taint",
108107
"org.springframework.web.util;UriComponentsBuilder;false;fromHttpRequest;;;Argument[0];ReturnValue;taint",
109108
"org.springframework.web.util;UriComponentsBuilder;false;fromHttpUrl;;;Argument[0];ReturnValue;taint",
110109
"org.springframework.web.util;UriComponentsBuilder;false;fromOriginHeader;;;Argument[0];ReturnValue;taint",
111110
"org.springframework.web.util;UriComponentsBuilder;false;fromPath;;;Argument[0];ReturnValue;taint",
112111
"org.springframework.web.util;UriComponentsBuilder;false;fromUri;;;Argument[0];ReturnValue;taint",
113112
"org.springframework.web.util;UriComponentsBuilder;false;fromUriString;;;Argument[0];ReturnValue;taint",
114-
"org.springframework.web.util;UriComponentsBuilder;false;host;;;Argument[-1];ReturnValue;value",
115-
"org.springframework.web.util;UriComponentsBuilder;false;host;;;Argument[0];Argument[-1];taint",
116113
"org.springframework.web.util;UriComponentsBuilder;false;parseForwardedFor;;;Argument[0..1];ReturnValue;taint",
117-
"org.springframework.web.util;UriComponentsBuilder;false;path;;;Argument[-1];ReturnValue;value",
118-
"org.springframework.web.util;UriComponentsBuilder;false;path;;;Argument[0];Argument[-1];taint",
119-
"org.springframework.web.util;UriComponentsBuilder;false;pathSegment;;;Argument[-1];ReturnValue;value",
120-
"org.springframework.web.util;UriComponentsBuilder;false;pathSegment;;;ArrayElement of Argument[0];Argument[-1];taint",
121-
"org.springframework.web.util;UriComponentsBuilder;false;port;;;Argument[-1];ReturnValue;value",
122-
"org.springframework.web.util;UriComponentsBuilder;false;port;(String);;Argument[0];Argument[-1];taint",
123-
"org.springframework.web.util;UriComponentsBuilder;false;query;;;Argument[-1];ReturnValue;value",
124-
"org.springframework.web.util;UriComponentsBuilder;false;query;;;Argument[0];Argument[-1];taint",
125-
"org.springframework.web.util;UriComponentsBuilder;false;queryParam;;;Argument[-1];ReturnValue;value",
126-
"org.springframework.web.util;UriComponentsBuilder;false;queryParam;;;Argument[0];Argument[-1];taint",
127-
"org.springframework.web.util;UriComponentsBuilder;false;queryParam;(String,Collection);;Element of Argument[1];Argument[-1];taint",
128-
"org.springframework.web.util;UriComponentsBuilder;false;queryParam;(String,Object[]);;ArrayElement of Argument[1];Argument[-1];taint",
129-
"org.springframework.web.util;UriComponentsBuilder;false;queryParamIfPresent;;;Argument[-1];ReturnValue;value",
130-
"org.springframework.web.util;UriComponentsBuilder;false;queryParamIfPresent;;;Argument[0];Argument[-1];taint",
131-
"org.springframework.web.util;UriComponentsBuilder;false;queryParamIfPresent;;;Element of Argument[1];Argument[-1];taint",
132-
"org.springframework.web.util;UriComponentsBuilder;false;queryParams;;;Argument[-1];ReturnValue;value",
133-
"org.springframework.web.util;UriComponentsBuilder;false;queryParams;;;MapKey of Argument[0];Argument[-1];taint",
134-
"org.springframework.web.util;UriComponentsBuilder;false;queryParams;;;Element of MapValue of Argument[0];Argument[-1];taint",
135-
"org.springframework.web.util;UriComponentsBuilder;false;replacePath;;;Argument[-1];ReturnValue;value",
136-
"org.springframework.web.util;UriComponentsBuilder;false;replacePath;;;Argument[0];Argument[-1];taint",
137-
"org.springframework.web.util;UriComponentsBuilder;false;replaceQuery;;;Argument[-1];ReturnValue;value",
138-
"org.springframework.web.util;UriComponentsBuilder;false;replaceQuery;;;Argument[0];Argument[-1];taint",
139-
"org.springframework.web.util;UriComponentsBuilder;false;replaceQueryParam;;;Argument[-1];ReturnValue;value",
140-
"org.springframework.web.util;UriComponentsBuilder;false;replaceQueryParam;;;Argument[0];Argument[-1];taint",
141-
"org.springframework.web.util;UriComponentsBuilder;false;replaceQueryParam;(String,Collection);;Element of Argument[1];Argument[-1];taint",
142-
"org.springframework.web.util;UriComponentsBuilder;false;replaceQueryParam;(String,Object[]);;ArrayElement of Argument[1];Argument[-1];taint",
143-
"org.springframework.web.util;UriComponentsBuilder;false;replaceQueryParams;;;Argument[-1];ReturnValue;value",
144-
"org.springframework.web.util;UriComponentsBuilder;false;replaceQueryParams;;;MapKey of Argument[0];Argument[-1];taint",
145-
"org.springframework.web.util;UriComponentsBuilder;false;replaceQueryParams;;;Element of MapValue of Argument[0];Argument[-1];taint",
146-
"org.springframework.web.util;UriComponentsBuilder;false;scheme;;;Argument[-1];ReturnValue;value",
147-
"org.springframework.web.util;UriComponentsBuilder;false;scheme;;;Argument[0];Argument[-1];taint",
148114
"org.springframework.web.util;UriComponentsBuilder;false;schemeSpecificPart;;;Argument[-1];ReturnValue;value",
149115
"org.springframework.web.util;UriComponentsBuilder;false;schemeSpecificPart;;;Argument[0];Argument[-1];taint",
150116
"org.springframework.web.util;UriComponentsBuilder;false;toUriString;;;Argument[-1];ReturnValue;taint",
@@ -154,8 +120,6 @@ private class FlowSummaries extends SummaryModelCsv {
154120
"org.springframework.web.util;UriComponentsBuilder;false;uriComponents;;;Argument[0];Argument[-1];taint",
155121
"org.springframework.web.util;UriComponentsBuilder;false;uriVariables;;;Argument[-1];ReturnValue;value",
156122
"org.springframework.web.util;UriComponentsBuilder;false;uriVariables;;;MapValue of Argument[0];Argument[-1];taint",
157-
"org.springframework.web.util;UriComponentsBuilder;false;userInfo;;;Argument[-1];ReturnValue;value",
158-
"org.springframework.web.util;UriComponentsBuilder;false;userInfo;;;Argument[0];Argument[-1];taint",
159123
"org.springframework.web.util;UriTemplate;false;expand;(Map);;MapValue of Argument[0];ReturnValue;taint",
160124
"org.springframework.web.util;UriTemplate;false;expand;(Object[]);;ArrayElement of Argument[0];ReturnValue;taint",
161125
"org.springframework.web.util;UriTemplate;false;getVariableNames;;;Argument[-1];Element of ReturnValue;taint",

0 commit comments

Comments
 (0)