Skip to content

Commit f150842

Browse files
committed
Add comment explaining tacky nature of code
1 parent 5b51a34 commit f150842

File tree

1 file changed

+8
-0
lines changed

1 file changed

+8
-0
lines changed

python/ql/src/semmle/python/dataflow/new/internal/DataFlowPrivate.qll

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -819,6 +819,14 @@ class DataFlowType extends TDataFlowType {
819819

820820
/** A node that performs a type cast. */
821821
class CastNode extends Node {
822+
// We include read- and store steps here to force them to be
823+
// shown in path explanations.
824+
// This hack is necessary, because we have included some of these
825+
// steps as default taint steps, making them be suppressed in path
826+
// explanations.
827+
// We should revert this once, we can remove this steps from the
828+
// default taint steps; this should be possible once we have
829+
// implemented flow summaries and recursive content.
822830
CastNode() { readStep(_, _, this) or storeStep(_, _, this) }
823831
}
824832

0 commit comments

Comments
 (0)