Skip to content

Commit f48eda8

Browse files
committed
C#: Rename some of the TBinarySignOperation constructors.
1 parent d92b226 commit f48eda8

File tree

2 files changed

+9
-9
lines changed

2 files changed

+9
-9
lines changed

csharp/ql/lib/semmle/code/csharp/dataflow/internal/rangeanalysis/RangeUtils.qll

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -394,21 +394,21 @@ module ExprNode {
394394
class LeftShiftExpr extends BinaryOperation {
395395
override CS::LeftShiftExpr e;
396396

397-
override TLShiftOp getOp() { any() }
397+
override TLeftShiftOp getOp() { any() }
398398
}
399399

400400
/** A right-shift operation. */
401401
class RightShiftExpr extends BinaryOperation {
402402
override CS::RightShiftExpr e;
403403

404-
override TRShiftOp getOp() { any() }
404+
override TRightShiftOp getOp() { any() }
405405
}
406406

407407
/** An unsigned right-shift operation. */
408408
class UnsignedRightShiftExpr extends BinaryOperation {
409409
override CS::UnsignedRightShiftExpr e;
410410

411-
override TURShiftOp getOp() { any() }
411+
override TUnsignedRightShiftOp getOp() { any() }
412412
}
413413

414414
/** A conditional expression. */

csharp/ql/lib/semmle/code/csharp/dataflow/internal/rangeanalysis/Sign.qll

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,9 @@ newtype TBinarySignOperation =
1818
TBitAndOp() or
1919
TBitOrOp() or
2020
TBitXorOp() or
21-
TLShiftOp() or
22-
TRShiftOp() or
23-
TURShiftOp()
21+
TLeftShiftOp() or
22+
TRightShiftOp() or
23+
TUnsignedRightShiftOp()
2424

2525
/** Class representing expression signs (+, -, 0). */
2626
class Sign extends TSign {
@@ -271,10 +271,10 @@ class Sign extends TSign {
271271
or
272272
op = TBitXorOp() and result = bitxor(s)
273273
or
274-
op = TLShiftOp() and result = lshift(s)
274+
op = TLeftShiftOp() and result = lshift(s)
275275
or
276-
op = TRShiftOp() and result = rshift(s)
276+
op = TRightShiftOp() and result = rshift(s)
277277
or
278-
op = TURShiftOp() and result = urshift(s)
278+
op = TUnsignedRightShiftOp() and result = urshift(s)
279279
}
280280
}

0 commit comments

Comments
 (0)