Skip to content

Commit f5e4b87

Browse files
Remove redundant rows and add note on collection flow
1 parent 1e3c4d0 commit f5e4b87

File tree

1 file changed

+1
-2
lines changed
  • java/ql/src/semmle/code/java/frameworks/guava

1 file changed

+1
-2
lines changed

java/ql/src/semmle/code/java/frameworks/guava/Base.qll

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,13 +21,12 @@ private class GuavaBaseCsv extends SummaryModelCsv {
2121
"com.google.common.base;Joiner;false;withKeyValueSeparator;(String);;Argument[0];ReturnValue;taint",
2222
"com.google.common.base;Joiner;false;withKeyValueSeparator;(String);;Argument[-1];ReturnValue;taint",
2323
"com.google.common.base;Joiner;false;withKeyValueSeparator;(char);;Argument[-1];ReturnValue;taint",
24-
"com.google.common.base;Joiner;false;appendTo;;;Argument;ReturnValue;taint",
24+
// Note: The signatures of some of the appendTo methods involve collection flow
2525
"com.google.common.base;Joiner;false;appendTo;;;Argument;Argument[0];taint",
2626
"com.google.common.base;Joiner;false;appendTo;;;Argument[0];ReturnValue;value",
2727
"com.google.common.base;Joiner;false;join;;;Argument;ReturnValue;taint",
2828
"com.google.common.base;Joiner$MapJoiner;false;useForNull;(String);;Argument[0];ReturnValue;taint",
2929
"com.google.common.base;Joiner$MapJoiner;false;useForNull;(String);;Argument[-1];ReturnValue;taint",
30-
"com.google.common.base;Joiner$MapJoiner;false;appendTo;;;Argument;ReturnValue;taint",
3130
"com.google.common.base;Joiner$MapJoiner;false;appendTo;;;Argument;Argument[0];taint",
3231
"com.google.common.base;Joiner$MapJoiner;false;appendTo;;;Argument[0];ReturnValue;value",
3332
"com.google.common.base;Joiner$MapJoiner;false;join;;;Argument;ReturnValue;taint",

0 commit comments

Comments
 (0)