Skip to content

Commit f7ad894

Browse files
author
Benjamin Muskalla
committed
Fix name of api filter predicate
1 parent 22df141 commit f7ad894

File tree

6 files changed

+6
-6
lines changed

6 files changed

+6
-6
lines changed

java/ql/src/Telemetry/ExternalAPI.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ class ExternalAPI extends Callable {
1616
ExternalAPI() { not this.fromSource() }
1717

1818
/** Holds if this API is a candidate worth supporting */
19-
predicate isWorthSupporting() { not isTestLibrary() and not isParameterlessConstructor() }
19+
predicate isUninteresting() { isTestLibrary() or isParameterlessConstructor() }
2020

2121
/** Holds if this API is is a constructor without parameters */
2222
predicate isParameterlessConstructor() {

java/ql/src/Telemetry/ExternalLibraryUsage.ql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,6 @@ where
1616
c.getCallee() = a and
1717
not c.getFile() instanceof GeneratedFile and
1818
a.jarContainer() = jarname and
19-
a.isWorthSupporting()
19+
not a.isUninteresting()
2020
)
2121
select jarname, usages order by usages desc

java/ql/src/Telemetry/SupportedExternalSinks.ql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ import semmle.code.java.GeneratedFiles
1212

1313
from ExternalAPI api, int usages
1414
where
15-
api.isWorthSupporting() and
15+
not api.isUninteresting() and
1616
api.isSink() and
1717
usages =
1818
strictcount(Call c |

java/ql/src/Telemetry/SupportedExternalSources.ql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ import semmle.code.java.GeneratedFiles
1212

1313
from ExternalAPI api, int usages
1414
where
15-
api.isWorthSupporting() and
15+
not api.isUninteresting() and
1616
api.isSource() and
1717
usages =
1818
strictcount(Call c |

java/ql/src/Telemetry/SupportedExternalTaint.ql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ import semmle.code.java.GeneratedFiles
1212

1313
from ExternalAPI api, int usages
1414
where
15-
api.isWorthSupporting() and
15+
not api.isUninteresting() and
1616
api.hasSummary() and
1717
usages =
1818
strictcount(Call c |

java/ql/src/Telemetry/UnsupportedExternalAPIs.ql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ import semmle.code.java.GeneratedFiles
1212

1313
from ExternalAPI api, int usages
1414
where
15-
api.isWorthSupporting() and
15+
not api.isUninteresting() and
1616
not api.isSupported() and
1717
usages =
1818
strictcount(Call c |

0 commit comments

Comments
 (0)