Update cpp/ql/src/Security/CWE/CWE-191/UnsignedDifferenceExpressionComparedZero.ql

geoffw0 · MathiasVP · web-flow · commit fc96c1c400b0 · 2021-05-07T16:26:23.000+01:00
Co-authored-by: Mathias Vorreiter Pedersen &lt;mathiasvp@github.com&gt;
diff --git a/cpp/ql/src/Security/CWE/CWE-191/UnsignedDifferenceExpressionComparedZero.ql b/cpp/ql/src/Security/CWE/CWE-191/UnsignedDifferenceExpressionComparedZero.ql
@@ -49,7 +49,7 @@ predicate exprIsSubLeftOrLess(SubExpr sub, DataFlow::Node n) {
   exists(DataFlow::Node other |
     // guard constraining `sub`
     exprIsSubLeftOrLess(sub, other) and
-    isGuarded(sub, other.asExpr(), n.asExpr()) // other >= e
+    isGuarded(sub, other.asExpr(), n.asExpr()) // other >= n
   )
   or
   exists(DataFlow::Node other, float p, float q |

Original file line number	Diff line number	Diff line change
`@@ -49,7 +49,7 @@ predicate exprIsSubLeftOrLess(SubExpr sub, DataFlow::Node n) {`
`49`	`49`	`exists(DataFlow::Node other \|`
`50`	`50`	// guard constraining `sub`
`51`	`51`	`exprIsSubLeftOrLess(sub, other) and`
`52`		`- isGuarded(sub, other.asExpr(), n.asExpr()) // other >= e`
	`52`	`+ isGuarded(sub, other.asExpr(), n.asExpr()) // other >= n`
`53`	`53`	`)`
`54`	`54`	`or`
`55`	`55`	`exists(DataFlow::Node other, float p, float q \|`