Skip to content

Commit fd1a14d

Browse files
committed
JS: Add qldoc to a private predicate
1 parent eed4204 commit fd1a14d

File tree

1 file changed

+7
-2
lines changed

1 file changed

+7
-2
lines changed

javascript/ql/src/semmle/javascript/dataflow/Configuration.qll

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -199,6 +199,10 @@ abstract class Configuration extends string {
199199
*/
200200
predicate isBarrierGuard(BarrierGuardNode guard) { none() }
201201

202+
/**
203+
* Holds if `guard` is a barrier guard for this configuration, added through
204+
* `isBarrierGuard` or `AdditionalBarrierGuardNode`.
205+
*/
202206
private predicate isBarrierGuardInternal(BarrierGuardNode guard) {
203207
isBarrierGuard(guard)
204208
or
@@ -319,7 +323,6 @@ module FlowLabel {
319323
* implementations of `blocks` will _both_ apply to any configuration that includes either of them.
320324
*/
321325
abstract class BarrierGuardNode extends DataFlow::Node {
322-
323326
/**
324327
* Holds if this node blocks expression `e` provided it evaluates to `outcome`.
325328
*
@@ -368,7 +371,9 @@ private predicate barrierGuardBlocksAccessPath(
368371
*
369372
* This predicate is outlined to give the optimizer a hint about the join ordering.
370373
*/
371-
private predicate barrierGuardBlocksSsaRefinement(BarrierGuardNode guard, boolean outcome, SsaRefinementNode ref, string label) {
374+
private predicate barrierGuardBlocksSsaRefinement(
375+
BarrierGuardNode guard, boolean outcome, SsaRefinementNode ref, string label
376+
) {
372377
guard.getEnclosingExpr() = ref.getGuard().getTest() and
373378
forex(SsaVariable input | input = ref.getAnInput() |
374379
barrierGuardBlocksExpr(guard, outcome, input.getAUse(), label)

0 commit comments

Comments
 (0)