Skip to content

Commit feaae16

Browse files
Jami CogswellJami Cogswell
authored andcommitted
Java: adjust comments
1 parent 29221ae commit feaae16

File tree

6 files changed

+9
-9
lines changed

6 files changed

+9
-9
lines changed

java/ql/lib/ext/java.sql.model.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,4 +28,4 @@ extensions:
2828
pack: codeql/java-all
2929
extensible: neutralModel
3030
data:
31-
- ["java.sql", "ResultSet", "next", "()", "manual"] # ! unsure if should be neutral model
31+
- ["java.sql", "ResultSet", "next", "()", "manual"]

java/ql/lib/ext/java.text.model.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,5 +3,5 @@ extensions:
33
pack: codeql/java-all
44
extensible: neutralModel
55
data:
6-
- ["java.text", "DateFormat", "format", "(Date)", "manual"] # ! unsure if should be neutral model, is flow through the param interesting in this case?
7-
- ["java.text", "SimpleDateFormat", "SimpleDateFormat", "(String)", "manual"] # ! unsure if should be neutral model, is flow through the param interesting in this case?
6+
- ["java.text", "DateFormat", "format", "(Date)", "manual"]
7+
- ["java.text", "SimpleDateFormat", "SimpleDateFormat", "(String)", "manual"]

java/ql/lib/ext/java.time.model.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,5 +4,5 @@ extensions:
44
extensible: neutralModel
55
data:
66
- ["java.time", "Instant", "now", "()", "manual"]
7-
- ["java.time", "LocalDate", "of", "(int,int,int)", "manual"] # ! unsure if should be neutral model, is flow through the param interesting in this case?
7+
- ["java.time", "LocalDate", "of", "(int,int,int)", "manual"]
88
- ["java.time", "ZonedDateTime", "now", "()", "manual"]

java/ql/lib/ext/java.util.function.model.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,11 +9,11 @@ extensions:
99
pack: codeql/java-all
1010
extensible: summaryModel
1111
data:
12-
- ["java.util.function", "Function", True, "apply", "(Object)", "", "Argument[0]", "ReturnValue", "taint", "manual"] # ! unsure if should be added as a MaD model and if model is correct
12+
- ["java.util.function", "Function", True, "apply", "(Object)", "", "Argument[0]", "ReturnValue", "taint", "manual"]
1313
- ["java.util.function", "Supplier", False, "get", "()", "", "Argument[-1]", "ReturnValue", "value", "manual"]
1414

1515
- addsTo:
1616
pack: codeql/java-all
1717
extensible: neutralModel
1818
data:
19-
- ["java.util.function", "Consumer", "accept", "(Object)", "manual"] # ! unsure if should be neutral model
19+
- ["java.util.function", "Consumer", "accept", "(Object)", "manual"]

java/ql/lib/ext/java.util.model.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -369,7 +369,7 @@ extensions:
369369
- ["java.util", "Collections", "emptyList", "()", "manual"]
370370
- ["java.util", "Collections", "emptyMap", "()", "manual"]
371371
- ["java.util", "Collections", "emptySet", "()", "manual"]
372-
- ["java.util", "Date", "Date", "(long)", "manual"] # ! unsure if should be neutral model, is flow through the param interesting in this case?
372+
- ["java.util", "Date", "Date", "(long)", "manual"]
373373
- ["java.util", "Date", "getTime", "()", "manual"]
374374
- ["java.util", "Iterator", "hasNext", "()", "manual"]
375375
- ["java.util", "List", "clear", "()", "manual"]

java/ql/lib/ext/java.util.stream.model.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ extensions:
9292
pack: codeql/java-all
9393
extensible: neutralModel
9494
data:
95-
- ["java.util.stream", "Collectors", "joining", "(CharSequence)", "manual"] # ! unsure if should be neutral model, is flow through the param interesting in this case?
95+
- ["java.util.stream", "Collectors", "joining", "(CharSequence)", "manual"]
9696
- ["java.util.stream", "Collectors", "toList", "()", "manual"]
97-
- ["java.util.stream", "Collectors", "toMap", "(Function,Function)", "manual"] # ! unsure if should be neutral model, is flow through the param interesting in this case?
97+
- ["java.util.stream", "Collectors", "toMap", "(Function,Function)", "manual"]
9898
- ["java.util.stream", "Collectors", "toSet", "()", "manual"]

0 commit comments

Comments
 (0)