Skip to content

Commit fed506a

Browse files
committed
Rename TrustedSource to SafeHeaderSplittingSource
1 parent 5f560e0 commit fed506a

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

java/ql/src/Security/CWE/CWE-113/ResponseSplitting.ql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ class ResponseSplittingConfig extends TaintTracking::Configuration {
1919

2020
override predicate isSource(DataFlow::Node source) {
2121
source instanceof RemoteFlowSource and
22-
not source instanceof TrustedSource
22+
not source instanceof SafeHeaderSplittingSource
2323
}
2424

2525
override predicate isSink(DataFlow::Node sink) { sink instanceof HeaderSplittingSink }

java/ql/src/Security/CWE/CWE-113/ServletResponseSplitting.qll

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,8 @@ class ServletHeaderSplittingSink extends HeaderSplittingSink {
3131
}
3232
}
3333

34-
class TrustedServletSource extends TrustedSource {
35-
TrustedServletSource() {
34+
class ServletSafeHeaderSplittingSource extends SafeHeaderSplittingSource {
35+
ServletSafeHeaderSplittingSource() {
3636
this.asExpr().(MethodAccess).getMethod() instanceof HttpServletRequestGetHeaderMethod or
3737
this.asExpr().(MethodAccess).getMethod() instanceof CookieGetNameMethod
3838
}

java/ql/src/semmle/code/java/security/ResponseSplitting.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,4 +8,4 @@ abstract class HeaderSplittingSink extends DataFlow::ExprNode { }
88
/**
99
* Sources that cannot be used to perform a header splitting attack.
1010
*/
11-
abstract class TrustedSource extends DataFlow::ExprNode { }
11+
abstract class SafeHeaderSplittingSource extends DataFlow::ExprNode { }

0 commit comments

Comments
 (0)