JS: Do not capture own variables

asgerf · asgerf · commit ff49aaa684b3 · 2021-07-02T13:17:32.000+02:00
diff --git a/javascript/ql/src/semmle/javascript/dataflow/internal/FlowSteps.qll b/javascript/ql/src/semmle/javascript/dataflow/internal/FlowSteps.qll
@@ -115,7 +115,8 @@ private module CachedSteps {
   cached
   predicate captures(Function f, LocalVariable variable, SsaVariableCapture cap) {
     variable = cap.getSourceVariable() and
-    f = cap.getContainer()
+    f = cap.getContainer() and
+    not f = variable.getDeclaringContainer()
   }
 
   /**

Original file line number	Diff line number	Diff line change
`@@ -115,7 +115,8 @@ private module CachedSteps {`
`115`	`115`	`cached`
`116`	`116`	`predicate captures(Function f, LocalVariable variable, SsaVariableCapture cap) {`
`117`	`117`	`variable = cap.getSourceVariable() and`
`118`		`- f = cap.getContainer()`
	`118`	`+ f = cap.getContainer() and`
	`119`	`+ not f = variable.getDeclaringContainer()`
`119`	`120`	`}`
`120`	`121`
`121`	`122`	`/**`