Skip to content

Commit ff58d5a

Browse files
committed
C++: Address review comments.
1 parent 9e75a4b commit ff58d5a

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

cpp/ql/test/library-tests/dataflow/taint-tests/localTaint.expected

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6033,10 +6033,12 @@
60336033
| taint.cpp:617:7:617:11 | ref arg dest3 | taint.cpp:618:8:618:12 | dest3 | |
60346034
| taint.cpp:618:8:618:12 | dest3 | taint.cpp:618:7:618:12 | * ... | TAINT |
60356035
| taint.cpp:625:33:625:38 | source | taint.cpp:628:17:628:22 | source | |
6036-
| taint.cpp:628:7:628:15 | call to _strnextc | taint.cpp:628:3:628:23 | ... = ... | |
6036+
| taint.cpp:628:7:628:15 | call to _strnextc | taint.cpp:628:3:628:25 | ... = ... | |
60376037
| taint.cpp:628:7:628:15 | call to _strnextc | taint.cpp:629:8:629:8 | c | |
60386038
| taint.cpp:628:7:628:15 | call to _strnextc | taint.cpp:630:10:630:10 | c | |
6039-
| taint.cpp:628:17:628:22 | source | taint.cpp:628:7:628:15 | call to _strnextc | TAINT |
6039+
| taint.cpp:628:17:628:22 | source | taint.cpp:628:17:628:24 | ... ++ | |
6040+
| taint.cpp:628:17:628:24 | ... ++ | taint.cpp:628:7:628:15 | call to _strnextc | TAINT |
6041+
| taint.cpp:628:17:628:24 | ... ++ | taint.cpp:628:17:628:22 | source | TAINT |
60406042
| taint.cpp:631:6:631:14 | call to _strnextc | taint.cpp:631:2:631:18 | ... = ... | |
60416043
| taint.cpp:631:6:631:14 | call to _strnextc | taint.cpp:632:7:632:7 | c | |
60426044
| taint.cpp:631:16:631:17 | | taint.cpp:631:6:631:14 | call to _strnextc | TAINT |

cpp/ql/test/library-tests/dataflow/taint-tests/taint.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -625,7 +625,7 @@ unsigned int _strnextc(const char*);
625625
void test__strnextc(const char* source) {
626626
unsigned c = 0;
627627
do {
628-
c = _strnextc(source);
628+
c = _strnextc(source++);
629629
sink(c); // $ ast,ir
630630
} while(c != '\0');
631631
c = _strnextc("");

0 commit comments

Comments
 (0)