Skip to content

Commit ffb22c0

Browse files
asgerferik-krogh
andauthored
Apply suggestions from code review
Co-authored-by: Erik Krogh Kristensen <[email protected]>
1 parent 897a3e3 commit ffb22c0

File tree

1 file changed

+6
-6
lines changed
  • javascript/ql/src/semmle/javascript/frameworks

1 file changed

+6
-6
lines changed

javascript/ql/src/semmle/javascript/frameworks/SQL.qll

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -32,21 +32,21 @@ private module MySql {
3232

3333
private DataFlow::CallNode createPool() { result = mysql().getAMemberCall("createPool") }
3434

35-
/** Gets a call to `mysql.createPool`. */
35+
/** Gets a reference to a MySQL pool. */
3636
private DataFlow::SourceNode pool(DataFlow::TypeTracker t) {
3737
t.start() and
3838
result = createPool()
3939
or
4040
exists(DataFlow::TypeTracker t2 | result = pool(t2).track(t2, t))
4141
}
4242

43-
/** Gets a call to `mysql.createPool`. */
43+
/** Gets a reference to a MySQL pool. */
4444
private DataFlow::SourceNode pool() { result = pool(DataFlow::TypeTracker::end()) }
4545

4646
/** Gets a call to `mysql.createConnection`. */
4747
DataFlow::CallNode createConnection() { result = mysql().getAMemberCall("createConnection") }
4848

49-
/** Gets a data flow node that contains a freshly created MySQL connection instance. */
49+
/** Gets a reference to a MySQL connection instance. */
5050
private DataFlow::SourceNode connection(DataFlow::TypeTracker t) {
5151
t.start() and
5252
(
@@ -58,7 +58,7 @@ private module MySql {
5858
exists(DataFlow::TypeTracker t2 | result = connection(t2).track(t2, t))
5959
}
6060

61-
/** Gets a data flow node that contains a freshly created MySQL connection instance. */
61+
/** Gets a reference to a MySQL connection instance. */
6262
DataFlow::SourceNode connection() { result = connection(DataFlow::TypeTracker::end()) }
6363

6464
/** A call to the MySql `query` method. */
@@ -318,15 +318,15 @@ private module Sequelize {
318318
/** Gets an import of the `sequelize` module. */
319319
DataFlow::SourceNode sequelize() { result = DataFlow::moduleImport("sequelize") }
320320

321-
/** Gets an expression that creates an instance of the `Sequelize` class. */
321+
/** Gets a node referring to an instance of the `Sequelize` class. */
322322
private DataFlow::SourceNode newSequelize(DataFlow::TypeTracker t) {
323323
t.start() and
324324
result = sequelize().getAnInstantiation()
325325
or
326326
exists(DataFlow::TypeTracker t2 | result = newSequelize(t2).track(t2, t))
327327
}
328328

329-
/** Gets an expression that creates an instance of the `Sequelize` class. */
329+
/** Gets a node referring to an instance of the `Sequelize` class. */
330330
DataFlow::SourceNode newSequelize() { result = newSequelize(DataFlow::TypeTracker::end()) }
331331

332332
/** A call to `Sequelize.query`. */

0 commit comments

Comments
 (0)