Add module-info or automatic module name

[Dunemaster]

Add module-info or automatic module name (in MANIFEST.MF) to facilitate work in JPMS environment

---

We have a library which should work both on android (earlier versions) and HotSpot, which means we cannot use JSR 310 types. But on "desktop" java we use JPMS, so making jackson-datatype-threetenbp a module would be nice.

I can do it myself, if any of the approaches is ok.

[Dunemaster]

@joschi , could you comment on this?
Are you ok with adding module-info?

[joschi]

@Dunemaster Thanks for bringing this up!

The module-info is already there (via the jackson-base Parent POM) but was never added to the artifact because the moditect-maven-plugin was missing.

This being said, it would be great if you could verify that this is working properly and maybe even had an idea how to test this automatically in our CI. 😄

➡️ https://github.com/joschi/jackson-datatype-threetenbp/actions?query=workflow%3A%22Main+workflow%22

[Dunemaster]

@joschi , that is great news!
But I could not build the project locally when I tried to verify it :(

Downloading from artifactory:
[ERROR] [ERROR] Some problems were encountered while processing the POMs:
[FATAL] Non-resolvable parent POM for com.github.joschi.jackson:jackson-datatype-threetenbp:2.11.4-SNAPSHOT: Could not transfer artifact com.fasterxml.jackson:jackson-base:pom:2.11.3 from/to artifactory : Transfer failed for and 'parent.relativePath' points at wrong local POM @ line 5, column 13

[joschi]

@Dunemaster Your artifact repository doesn't have a copy of com.fasterxml.jackson:jackson-base:2.11.3. 🤷

[Dunemaster]

@joschi , yes, I do understand
Where can it be found? Which repository should I connect?

[joschi]

Where can it be found? Which repository should I connect?

It's available on Maven Central:

• https://search.maven.org/artifact/com.fasterxml.jackson/jackson-base/2.11.3/pom
• https://mvnrepository.com/artifact/com.fasterxml.jackson/jackson-base/2.11.3

Maybe the admins of your private artifact repository boreas.dept07 have to make it available explicitly.

[Dunemaster]

@joschi , thanks, there was an issue with repository mirroring

[Dunemaster]

The resulting module does not export com.fasterxml.jackson.datatype.threetenbp.function
Is that right?

[joschi]

The resulting module does not export com.fasterxml.jackson.datatype.threetenbp.function

I've added the missing export for com.fasterxml.jackson.datatype.threetenbp.function and requirement on org.threeten.bp.

[joschi]

@Dunemaster Did you have a chance to check the latest releases/changes?