Skip to content

Commit e8628b9

Browse files
authored
chore: fix test suite in Node 22 (#1642)
Node now provides a `navigator` global (https://nodejs.org/api/globals.html#navigator_1), which could cause JSONEditor's test suite to fail with the following error. ``` Exception during run: TypeError: Cannot set property navigator of #<Object> which has only a getter at setUpTestEnvironment (jsoneditor/test/setup.js:16:19) at Object.<anonymous> (jsoneditor/test/setup.js:22:1) ```
1 parent 4dbd88e commit e8628b9

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

test/setup.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,9 @@ function setUpTestEnvironment (locale) {
1313
const dom = new JSDOM('...')
1414
global.window = dom.window
1515
global.document = dom.window.document
16-
global.navigator = dom.window.navigator
16+
if (typeof global.navigator === 'undefined') {
17+
global.navigator = dom.window.navigator
18+
}
1719

1820
// JSDom has no setter defined for navigator.language, so defineProperty is necessary in order to override it
1921
Object.defineProperty(navigator, 'language', { value: locale })

0 commit comments

Comments
 (0)