Skip to content

Commit a51ee3a

Browse files
skv0zsnegjose-reveni
authored andcommitted
Fix postgres OrderableAggMixin & BTreeIndex (typeddjango#2686)
1 parent 7be53d6 commit a51ee3a

File tree

3 files changed

+6
-3
lines changed

3 files changed

+6
-3
lines changed

django-stubs/contrib/postgres/aggregates/mixins.pyi

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,11 @@ from typing_extensions import Self
99
class OrderableAggMixin:
1010
order_by: OrderByList
1111
def __init__(
12-
self, *expressions: BaseExpression | Combinable | str, ordering: Sequence[str] = ..., **extra: Any
12+
self,
13+
*expressions: BaseExpression | Combinable | str,
14+
ordering: Sequence[str] = ...,
15+
order_by: Sequence[str] = ...,
16+
**extra: Any,
1317
) -> None: ...
1418
def resolve_expression(self, *args: Any, **kwargs: Any) -> Self: ...
1519
def get_source_expressions(self) -> list[Expression]: ...

django-stubs/contrib/postgres/indexes.pyi

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,7 @@ class BTreeIndex(PostgresIndex):
5151
self,
5252
*expressions: BaseExpression | Combinable | str,
5353
fillfactor: int | None = None,
54+
deduplicate_items: bool | None = None,
5455
fields: Sequence[str] = ...,
5556
name: str | None = ...,
5657
db_tablespace: str | None = ...,

scripts/stubtest/allowlist_todo_django52.txt

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,6 @@ django.contrib.gis.management
3535
django.contrib.gis.management.commands
3636
django.contrib.gis.management.commands.inspectdb
3737
django.contrib.gis.management.commands.ogrinspect
38-
django.contrib.postgres.aggregates.mixins.OrderableAggMixin.__init__
39-
django.contrib.postgres.indexes.BTreeIndex.__init__
4038
django.contrib.sessions.backends.base.SessionBase.pop
4139
django.core.checks.Tags.commands
4240
django.core.checks.commands

0 commit comments

Comments
 (0)