Skip to content

Commit b99303c

Browse files
cjwatsonjose-reveni
authored andcommitted
Weaken response argument types in django.utils.cache (typeddjango#2704)
These functions just look at response headers, so `HttpResponseBase` is perfectly fine. This is useful when working with responses returned by methods such as `django.test.Client.get`.
1 parent 4017cec commit b99303c

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

django-stubs/utils/cache.pyi

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ from django.http.response import HttpResponse, HttpResponseBase
88
cc_delim_re: Any
99

1010
def patch_cache_control(response: HttpResponseBase, **kwargs: Any) -> None: ...
11-
def get_max_age(response: HttpResponse) -> int | None: ...
11+
def get_max_age(response: HttpResponseBase) -> int | None: ...
1212
def set_response_etag(response: HttpResponseBase) -> HttpResponseBase: ...
1313
def get_conditional_response(
1414
request: HttpRequest,
@@ -19,13 +19,13 @@ def get_conditional_response(
1919
def patch_response_headers(response: HttpResponseBase, cache_timeout: int | None = ...) -> None: ...
2020
def add_never_cache_headers(response: HttpResponseBase) -> None: ...
2121
def patch_vary_headers(response: HttpResponseBase, newheaders: Iterable[str]) -> None: ...
22-
def has_vary_header(response: HttpResponse, header_query: str) -> bool: ...
22+
def has_vary_header(response: HttpResponseBase, header_query: str) -> bool: ...
2323
def get_cache_key(
2424
request: HttpRequest, key_prefix: str | None = ..., method: str = ..., cache: BaseCache | None = ...
2525
) -> str | None: ...
2626
def learn_cache_key(
2727
request: HttpRequest,
28-
response: HttpResponse,
28+
response: HttpResponseBase,
2929
cache_timeout: float | None = ...,
3030
key_prefix: str | None = ...,
3131
cache: BaseCache | None = ...,

0 commit comments

Comments
 (0)