Skip to content
This repository was archived by the owner on Feb 18, 2023. It is now read-only.

Commit 37dda7c

Browse files
authored
Merge pull request #28 from kslimani/upgrade-laravel-permission
[PROPOSAL] Upgrade laravel permission to 2.4
2 parents 76f1649 + 058762f commit 37dda7c

File tree

10 files changed

+236
-283
lines changed

10 files changed

+236
-283
lines changed

app/Entities/Permission.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,5 +14,5 @@ class Permission extends \Spatie\Permission\Models\Permission
1414
/**
1515
* @var array
1616
*/
17-
protected $fillable = ['name', 'uuid'];
17+
protected $fillable = ['name', 'uuid', 'guard_name'];
1818
}

app/Entities/Role.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,5 +15,5 @@ class Role extends \Spatie\Permission\Models\Role
1515
/**
1616
* @var array
1717
*/
18-
protected $fillable = ['name', 'uuid'];
18+
protected $fillable = ['name', 'uuid', 'guard_name'];
1919
}

app/Support/HasPermissionsUuid.php

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,8 @@
22

33
namespace App\Support;
44

5-
use App\Entities\Permission;
5+
use Spatie\Permission\Contracts\Permission;
6+
use App\Entities\Permission as PermissionEntity;
67

78
/**
89
* Class HasPermissionsUuid.
@@ -16,14 +17,14 @@ trait HasPermissionsUuid
1617
*
1718
* @return Permission
1819
*/
19-
protected function getStoredPermission($permissions)
20+
protected function getStoredPermission($permissions): Permission
2021
{
2122
if (is_string($permissions)) {
22-
return app(Permission::class)->where('name', $permissions)->orWhere('uuid', $permissions)->first();
23+
return app(PermissionEntity::class)->where('name', $permissions)->orWhere('uuid', $permissions)->first();
2324
}
2425

2526
if (is_array($permissions)) {
26-
return app(Permission::class)->whereIn('name', $permissions)->orWhereIn('uuid', $permissions)->get();
27+
return app(PermissionEntity::class)->whereIn('name', $permissions)->orWhereIn('uuid', $permissions)->get();
2728
}
2829

2930
return $permissions;

app/Support/HasRolesUuid.php

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,8 @@
22

33
namespace App\Support;
44

5-
use App\Entities\Role;
5+
use App\Entities\Role as RoleEntity;
6+
use Spatie\Permission\Contracts\Role;
67

78
trait HasRolesUuid
89
{
@@ -11,10 +12,10 @@ trait HasRolesUuid
1112
*
1213
* @return Role
1314
*/
14-
protected function getStoredRole($role)
15+
protected function getStoredRole($role): Role
1516
{
1617
if (is_string($role)) {
17-
return app(Role::class)->where('name', $role)->orWhere('uuid', $role)->first();
18+
return app(RoleEntity::class)->where('name', $role)->orWhere('uuid', $role)->first();
1819
}
1920

2021
return $role;

composer.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,12 +14,12 @@
1414
],
1515
"require": {
1616
"php": ">=7.0.0",
17+
"dingo/api": "1.0.*@dev",
1718
"laravel/framework": "5.4.*",
1819
"laravel/passport": "^3.0",
1920
"laravel/tinker": "~1.0",
2021
"predis/predis": "^1.1",
21-
"dingo/api": "1.0.*@dev",
22-
"spatie/laravel-permission": "^1.7",
22+
"spatie/laravel-permission": "^2.4",
2323
"webpatser/laravel-uuid": "^2.0"
2424
},
2525
"require-dev": {

0 commit comments

Comments
 (0)