- Generate personal access token from the console

- Validate user creation on installation service
- Bcrypt user password on creation from the installation service.

Author: joselfonseca

app/Console/Kernel.php

@@ -25,8 +25,7 @@ class Kernel extends ConsoleKernel
      */
     protected function schedule(Schedule $schedule)
     {
-        // $schedule->command('inspire')
-        //          ->hourly();
+
     }
 
     /**

app/Services/Installation/InstallAppHandler.php

@@ -6,6 +6,7 @@
 use App\Entities\User;
 use App\Entities\Permission;
 use App\Services\Installation\Events\ApplicationWasInstalled;
+use Illuminate\Validation\ValidationException;
 
 /**
  * Class InstallAppHandler
@@ -98,14 +99,22 @@ public function createPermissions()
     /**
      * @param array $attributes
      * @return $this
+     * @throws ValidationException
      */
     public function createAdminUser(array $attributes = [])
     {
+        $validator = validator($attributes, [
+            'name' => 'required',
+            'email' => 'required|email|unique:users,email',
+            'password' => 'required|min:8|confirmed'
+        ]);
+        if($validator->fails()) {
+            throw new ValidationException($validator);
+        }
         $this->adminUser = User::create([
             'name' => $attributes['name'],
             'email' => $attributes['email'],
-            'password' => $attributes['password'],
-            'password_confirmation' => $attributes['password_confirmation']
+            'password' => bcrypt($attributes['password'])
         ]);
         return $this;
     }

routes/console.php

@@ -13,6 +13,9 @@
 |
 */
 
-Artisan::command('inspire', function () {
-    $this->comment(Inspiring::quote());
-})->describe('Display an inspiring quote');
+Artisan::command('dev:generate-personal-token {userId}', function ($userId) {
+    $user = \App\Entities\User::find($userId);
+    $this->info('Token for user '.$user->name);
+    $token = $user->createToken('Personal Access Token')->accessToken;
+    $this->info($token);
+})->describe('Generates a personal access token for a user');

tests/Unit/Services/Installation/InstallAppHandlerTest.php

@@ -2,6 +2,7 @@
 
 namespace Tests\Unit\Services\Installation;
 
+use Illuminate\Validation\ValidationException;
 use Tests\TestCase;
 use Illuminate\Foundation\Testing\DatabaseMigrations;
 
@@ -60,6 +61,22 @@ function test_it_creates_admin_user()
         $this->assertNotNull($user->uuid);
     }
 
+    function test_it_validates_input_for_creating_user()
+    {
+        $handler = $this->makeHandler();
+        try{
+            $handler->createAdminUser([
+                'name' => 'Jose Fonseca',
+            ]);
+            $this->fail('Validation to create user did not run.');
+        } catch (ValidationException $e) {
+            $this->assertDatabaseMissing('users', [
+                'name' => 'Jose Fonseca',
+                'email' => '[email protected]',
+            ]);
+        }
+    }
+
     function test_it_assigns_admin_role_to_admin_user()
     {
         $handler = $this->makeHandler();