improve coverage.

Author: Jose Fonseca

app/Http/Controllers/Api/Assets/UploadFileController.php

@@ -156,18 +156,12 @@ protected function storeInFileSystem(array $attributes)
     /**
      * @param $url
      * @return \Psr\Http\Message\ResponseInterface
+     * @throws \GuzzleHttp\Exception\GuzzleException
      */
     protected function callFileUrl($url)
     {
         try {
-            $response = $this->client->get($url);
-            if ($response->getStatusCode() != 200) {
-                throw new StoreResourceFailedException('Validation Error', [
-                    'url' => 'The url seems unreachable',
-                ]);
-            }
-
-            return $response;
+            return $this->client->get($url);
         } catch (TransferException $e) {
             throw new StoreResourceFailedException('Validation Error', [
                 'url' => 'The url seems to be unreachable: '.$e->getCode(),

app/Services/Installation/InstallAppCommand.php

@@ -1,38 +1,27 @@
 <?xml version="1.0" encoding="UTF-8"?>
-    <phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
-             xsi:noNamespaceSchemaLocation="./vendor/phpunit/phpunit/phpunit.xsd"
-             backupGlobals="false"
-             backupStaticAttributes="false"
-             bootstrap="vendor/autoload.php"
-             colors="true"
-             convertErrorsToExceptions="true"
-             convertNoticesToExceptions="true"
-             convertWarningsToExceptions="true"
-             processIsolation="false"
-             stopOnFailure="false">
-    <testsuites>
-        <testsuite name="Unit">
-            <directory suffix="Test.php">./tests/Unit</directory>
-        </testsuite>
-
-        <testsuite name="Feature">
-            <directory suffix="Test.php">./tests/Feature</directory>
-        </testsuite>
-    </testsuites>
-    <filter>
-        <whitelist processUncoveredFilesFromWhitelist="true">
-            <directory suffix=".php">./app</directory>
-        </whitelist>
-    </filter>
-    <php>
-        <server name="APP_ENV" value="testing"/>
-        <server name="BCRYPT_ROUNDS" value="4"/>
-        <server name="CACHE_DRIVER" value="array"/>
-        <server name="MAIL_DRIVER" value="array"/>
-        <server name="QUEUE_CONNECTION" value="sync"/>
-        <server name="SESSION_DRIVER" value="array"/>
-        <env name="DB_CONNECTION" value="sqlite"/>
-        <env name="DB_DATABASE" value=":memory:"/>
-        <env name="API_VERSION" value="v1"/>
-    </php>
+<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/9.3/phpunit.xsd" backupGlobals="false" backupStaticAttributes="false" bootstrap="vendor/autoload.php" colors="true" convertErrorsToExceptions="true" convertNoticesToExceptions="true" convertWarningsToExceptions="true" processIsolation="false" stopOnFailure="false">
+  <coverage processUncoveredFiles="true">
+    <include>
+      <directory suffix=".php">./app</directory>
+    </include>
+  </coverage>
+  <testsuites>
+    <testsuite name="Unit">
+      <directory suffix="Test.php">./tests/Unit</directory>
+    </testsuite>
+    <testsuite name="Feature">
+      <directory suffix="Test.php">./tests/Feature</directory>
+    </testsuite>
+  </testsuites>
+  <php>
+    <server name="APP_ENV" value="testing"/>
+    <server name="BCRYPT_ROUNDS" value="4"/>
+    <server name="CACHE_DRIVER" value="array"/>
+    <server name="MAIL_DRIVER" value="array"/>
+    <server name="QUEUE_CONNECTION" value="sync"/>
+    <server name="SESSION_DRIVER" value="array"/>
+    <env name="DB_CONNECTION" value="sqlite"/>
+    <env name="DB_DATABASE" value=":memory:"/>
+    <env name="API_VERSION" value="v1"/>
+  </php>
 </phpunit>

phpunit.xml

@@ -140,4 +140,17 @@ function test_it_validates_mime_on_url()
         $this->assertArrayHasKey('Content-Type', $jsonResponse['errors']);
 
     }
+
+    function test_it_validates_url()
+    {
+        Passport::actingAs(
+            factory(User::class)->create()
+        );
+        $response = $this->json('POST', 'api/assets', [
+            'url' => 'http://somedomain.com/350x150'
+        ]);
+        $jsonResponse = json_decode($response->getContent(), true);
+        $this->assertEquals(422, $response->getStatusCode());
+        $this->assertArrayHasKey('Content-Type', $jsonResponse['errors']);
+    }
 }