Skip to content

Commit 7b8259b

Browse files
Use define instead of #![deny(warning)] (#1290)
Setting #![deny(warnings) in the source can cause josh fail to build on different versions of rustc. This way we only ensure there are no warnings on our "officially supported" rustc version, but allow building on other versions as well. Change: warnings
1 parent 465dd8f commit 7b8259b

File tree

4 files changed

+2
-2
lines changed

4 files changed

+2
-2
lines changed

.github/workflows/rust.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ on:
88

99
env:
1010
CARGO_TERM_COLOR: always
11+
RUSTFLFAGS: "-D warnings"
1112

1213
jobs:
1314
build:

josh-filter/src/bin/josh-filter.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
#![deny(warnings)]
21
#![warn(unused_extern_crates)]
32

43
#[macro_use]

josh-proxy/src/bin/josh-proxy.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
#![deny(warnings)]
21
#[macro_use]
32
extern crate lazy_static;
43
extern crate clap;

tester.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,7 @@ if [[ ! -v CARGO_TARGET_DIR ]]; then
4848
exit 1
4949
fi
5050
51+
export RUSTFLFAGS="-D warnings"
5152
cargo build --workspace --exclude josh-ui --features hyper_cgi/test-server
5253
( cd josh-ssh-dev-server ; go build -o "\${CARGO_TARGET_DIR}/josh-ssh-dev-server" )
5354
sh run-tests.sh ${TESTS}

0 commit comments

Comments
 (0)