Fix bugs in resource serialization.

- parsing related resources lead to a crash
- timestamps in test fixtures did not match parser string for RFC3339DateFormatter

Author: Julian Krumow

Classes/JSONAPI.m

@@ -171,32 +171,38 @@ - (void)inflateWithDictionary:(NSDictionary*)dictionary {
 
 - (void)inflateWithResource:(NSObject <JSONAPIResource> *)resource
 {
-    NSMutableArray *resourceArray = [[NSMutableArray alloc] init];
-    [resourceArray addObject:resource];
-    _resources = resourceArray;
+    _resources = @[resource];
 
-    NSMutableDictionary *newDictionary = [[NSMutableDictionary alloc] init];
+    NSMutableDictionary *dictionary = [[NSMutableDictionary alloc] init];
+    dictionary[@"data"] = [JSONAPIResourceParser dictionaryFor:resource];
 
-    newDictionary[@"data"] = [JSONAPIResourceParser dictionaryFor:resource];
-    
-    NSArray *included = [JSONAPIResourceParser relatedResourcesFor:resource];
-    if (included.count) {
-        newDictionary[@"included"] = included;
-        
-        NSMutableDictionary *includedResources = [[NSMutableDictionary alloc] init];
-        for (NSObject <JSONAPIResource> *linked in included) {
-            
-            JSONAPIResourceDescriptor *desc = [[linked class] descriptor];
-            
-            NSMutableDictionary *typeDict = includedResources[desc.type] ?: @{}.mutableCopy;
-            typeDict[linked.ID] = resource;
-            
-            includedResources[desc.type] = typeDict;
-        }
-        _includedResources = includedResources;
+    NSArray *relatedResources = [JSONAPIResourceParser relatedResourcesFor:resource];
+    if (relatedResources.count) {
+        _includedResources = [self mapIncludedResources:relatedResources forResource:resource];
+        dictionary[@"included"] = [self parseRelatedResources:relatedResources];
     }
-    
-    _dictionary = newDictionary;
+    _dictionary = dictionary;
+}
+
+- (NSDictionary *)mapIncludedResources:(NSArray *)relatedResources forResource:(NSObject <JSONAPIResource> *)resource
+{
+    NSMutableDictionary *includedResources = [NSMutableDictionary new];
+    for (NSObject <JSONAPIResource> *linked in relatedResources) {
+        JSONAPIResourceDescriptor *desc = [[linked class] descriptor];
+        NSMutableDictionary *typeDict = includedResources[desc.type] ?: @{}.mutableCopy;
+        typeDict[linked.ID] = resource;
+        includedResources[desc.type] = typeDict;
+    }
+    return includedResources;
+}
+
+- (NSArray *)parseRelatedResources:(NSArray *)relatedResources
+{
+    NSMutableArray *parsedResources = [NSMutableArray new];
+    for (NSObject <JSONAPIResource> *linked in relatedResources) {
+        [parsedResources addObject:[JSONAPIResourceParser dictionaryFor:linked]];
+    }
+    return parsedResources;
 }
 
 @end

Classes/JSONAPIResourceParser.m

@@ -338,20 +338,15 @@ + (NSArray*)relatedResourcesFor:(NSObject <JSONAPIResource>*)resource {
     NSDictionary *properties = [descriptor properties];
     for (NSString *key in properties) {
         JSONAPIPropertyDescriptor *property = [properties objectForKey:key];
-        
         if (property.resourceType) {
-            id value = [self valueForKey:key];
+            id value = [resource valueForKey:key];
             if ([value isKindOfClass:[NSArray class]]) {
-                for (NSObject <JSONAPIResource> *element in value) {
-                    [related addObject:[JSONAPIResourceParser dictionaryFor:element]];
-                }
+                [related addObjectsFromArray:value];
             } else {
-                NSObject <JSONAPIResource> *attribute = value;
-                [related addObject:[JSONAPIResourceParser dictionaryFor:attribute]];
+                [related addObject:value];
             }
         }
     }
-    
     return related;
 }
 

Project/JSONAPITests/JSONAPITests.m

@@ -12,6 +12,7 @@
 #import "JSONAPIResourceDescriptor.h"
 #import "JSONAPIErrorResource.h"
 #import "JSONAPIResourceParser.h"
+#import "NSDateFormatter+JSONAPIDateFormatter.h"
 
 #import "CommentResource.h"
 #import "PeopleResource.h"
@@ -68,7 +69,8 @@ - (void)testDataArticles {
     XCTAssertTrue([article.selfLink isEqualToString:@"http://example.com/articles/1"], @"Article selfLink should be 'http://example.com/articles/1'");
     XCTAssertEqualObjects(article.title, @"JSON API paints my bikeshed!", @"Article title should be 'JSON API paints my bikeshed!'");
 
-	NSArray *dateStrings = @[@"2015-09-01T12:15:00Z",@"2015-08-01T06:15:00Z"];
+	NSArray *dateStrings = @[[[NSDateFormatter RFC3339DateFormatter] dateFromString:@"2015-09-01T12:15:00.000Z"],
+                             [[NSDateFormatter RFC3339DateFormatter] dateFromString:@"2015-08-01T06:15:00.000Z"]];
 	XCTAssertEqualObjects(article.versions, dateStrings, @"Article versions should contain an array of date strings");
 }
 
@@ -182,13 +184,21 @@ - (void)testSerializeComplex {
 }
 
 - (void)testCreate {
-  PeopleResource *newAuthor = [[PeopleResource alloc] init];
-  
-  newAuthor.firstName = @"Karl";
-  newAuthor.lastName = @"Armstrong";
-  
-  JSONAPI *jsonAPI = [JSONAPI jsonAPIWithResource:newAuthor];
-  XCTAssertEqualObjects([jsonAPI dictionary][@"data"][@"type"], @"people", @"Did not create person!");
+    NSDictionary *json = [self mainExampleJSON];
+    JSONAPI *jsonAPI = [JSONAPI jsonAPIWithDictionary:json];
+    
+    ArticleResource *article = jsonAPI.resource;
+    
+    jsonAPI = [JSONAPI jsonAPIWithResource:article];
+    NSDictionary *dictionary = [jsonAPI dictionary];
+    XCTAssertEqualObjects(dictionary[@"data"][@"type"], @"articles", @"Did not create article!");
+    XCTAssertEqualObjects(dictionary[@"data"][@"attributes"][@"title"], @"JSON API paints my bikeshed!", @"Did not parse title!");
+    XCTAssertEqual([dictionary[@"data"][@"relationships"][@"comments"][@"data"] count], 2, @"Did not parse relationships!");
+    XCTAssertEqual([dictionary[@"included"] count], 3, @"Did not parse included resources!");
+    XCTAssertEqualObjects(dictionary[@"included"][0][@"type"], @"people", @"Did not parse included people object!");
+    XCTAssertEqualObjects(dictionary[@"included"][0][@"id"], @"9", @"Did not parse ID!");
+    XCTAssertEqualObjects(dictionary[@"included"][1][@"type"], @"comments", @"Did not parse included comments object!");
+    XCTAssertEqualObjects(dictionary[@"included"][1][@"relationships"][@"author"][@"data"][@"type"], @"people", @"Did not parse included comments author!");
 }
 
 #pragma mark - Generic relationships tests

Project/JSONAPITests/main_example.json

@@ -13,8 +13,8 @@
     "attributes": {
 			 "title": "JSON API paints my bikeshed!",
              "versions": [
-                "2015-09-01T12:15:00Z",
-                "2015-08-01T06:15:00Z"
+                "2015-09-01T12:15:00.000Z",
+                "2015-08-01T06:15:00.000Z"
              ]
     },
     "relationships": {