Improved error message fallback logic (#35)

Author: tadam313

ingest_test.go

@@ -131,6 +131,34 @@ func TestExamplesInTheWild(t *testing.T) {
 				assert.Equal(t, testcase, suites[0].Tests[0])
 			},
 		},
+		{
+			title:    "fastlane example",
+			filename: "testdata/fastlane-trainer.xml",
+			check: func(t *testing.T, suites []Suite) {
+				assert.Len(t, suites, 1)
+				assert.Len(t, suites[0].Tests, 4)
+
+				var testcase = Test{
+					Name:      "testSomething()",
+					Classname: "TestClassSample",
+					Duration:  342 * time.Millisecond,
+					Status:    StatusFailed,
+					Error: Error{
+						Message: "XCTAssertTrue failed",
+						Body:    "\n            ",
+					},
+					Properties: map[string]string{
+						"classname": "TestClassSample",
+						"name":      "testSomething()",
+						"time":      "0.342",
+					},
+				}
+
+				assert.Equal(t, testcase, suites[0].Tests[2])
+				assert.EqualError(t, suites[0].Tests[2].Error, "XCTAssertTrue failed")
+				assert.EqualError(t, suites[0].Tests[3].Error, "NullPointerException")
+			},
+		},
 	}
 
 	for index, test := range tests {

testdata/fastlane-trainer.xml

@@ -0,0 +1,17 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<testsuites tests="4" failures="2">
+    <testsuite name="UnitTests" tests="4" failures="2">
+        <testcase classname="TestClass" name="testName()" time="0.45252">
+        </testcase>
+        <testcase classname="TestClass" name="testLaunch1()" time="0.2542">
+        </testcase>
+        <testcase classname="TestClassSample" name="testSomething()" time="0.342">
+            <failure message="XCTAssertTrue failed">
+            </failure>
+        </testcase>
+        <testcase classname="TestClassSample" name="testSomething2()" time="0.441">
+            <failure type="NullPointerException">
+            </failure>
+        </testcase>
+    </testsuite>
+</testsuites>

types.go

@@ -4,7 +4,10 @@
 
 package junit
 
-import "time"
+import (
+	"strings"
+	"time"
+)
 
 // Status represents the result of a single a JUnit testcase. Indicates if a
 // testcase was run, and if it was successful.
@@ -156,5 +159,14 @@ type Error struct {
 
 // Error returns a textual description of the test error.
 func (err Error) Error() string {
-	return err.Body
+	switch {
+	case strings.TrimSpace(err.Body) != "":
+		return err.Body
+
+	case strings.TrimSpace(err.Message) != "":
+		return err.Message
+
+	default:
+		return err.Type
+	}
 }