Passing (or xfailing) test_array tests

Author: joshmoore

src/zarr/core/common.py

@@ -168,6 +168,9 @@ def parse_bool(data: Any) -> bool:
 
 
 def parse_dtype(dtype: Any, zarr_format: ZarrFormat) -> np.dtype[Any]:
+    if "datatype" in type(dtype).__name__.lower():
+        # Workaround until we have the class in place
+        return dtype.to_numpy()  # TODO: call conversion method
     if dtype is str or dtype == "str":
         if zarr_format == 2:
             # special case as object

src/zarr/core/metadata/v3.py

@@ -659,7 +659,7 @@ def to_numpy_shortname(self) -> str:
             DataType.float64: "f8",
             DataType.complex64: "c8",
             DataType.complex128: "c16",
-            DataType.example: np.dtype(object),
+            DataType.example: "bool",  # Something numpy-ish
         }
         return data_type_to_numpy[self]
 

src/zarr/registry.py

@@ -53,6 +53,7 @@ def register(self, cls: type[T]) -> None:
 __pipeline_registry: Registry[CodecPipeline] = Registry()
 __buffer_registry: Registry[Buffer] = Registry()
 __ndbuffer_registry: Registry[NDBuffer] = Registry()
+__dtype_registry: Registry[DataType] = Registry()
 
 """
 The registry module is responsible for managing implementations of codecs,

tests/test_array.py

@@ -1444,3 +1444,36 @@ async def test_sharding_coordinate_selection() -> None:
     )
     arr[:] = np.arange(2 * 3 * 4).reshape((2, 3, 4))
     assert (arr[1, [0, 1]] == np.array([[12, 13, 14, 15], [16, 17, 18, 19]])).all()  # type: ignore[index]
+
+
+@pytest.mark.xfail(reason="zarr.common.core maps any string to the string type")
+async def test_array_v3_ext_uri_by_string(
+) -> None:
+    """
+    Test the user impact of the extension mechanism
+    """
+    store = MemoryStore()
+    g = zarr.open_group(store, mode="w")
+    arr = g.create_array(
+        name="a",
+        dtype="https://example.com",  # Or require here a DataType instance
+        shape=(12,),
+        chunks=(3,),
+    )
+    assert arr.data_type == None  # TODO: import the example dtype
+
+
+async def test_array_v3_ext_uri_by_class(
+) -> None:
+    """
+    Test the user impact of the extension mechanism
+    """
+    store = MemoryStore()
+    g = zarr.open_group(store, mode="w")
+    arr = g.create_array(
+        name="a",
+        dtype=DataType.example,
+        shape=(12,),
+        chunks=(3,),
+    )
+    assert arr.dtype == np.dtype(bool)