refactor(tui): migrate SqlQueryScreen to TuiScreenBase, remove all PPDS013 pragmas

joshsmithxrm · claude · joshsmithxrm · commit c7f130046144 · 2026-02-07T12:05:25.000-06:00
I2: SqlQueryScreen now extends TuiScreenBase — removes manual Content
view, hotkey registration/cleanup, dispose boilerplate, and
_environmentUrl/_session/_errorService fields. Uses Session,
ErrorService, ScreenCancellation, RegisterHotkey(), RequestClose(),
NotifyMenuChanged() from base class. CancellationToken.None replaced
with ScreenCancellation throughout.

I4: Remove all remaining #pragma PPDS013 blocks from dialogs. Update
PPDS013 analyzer to recognize FireAndForget (including null-conditional
?.FireAndForget) as a safe pattern, eliminating the need for pragma
suppression at call sites. Migrate ContinueWith error handling in
ClearAllProfilesDialog, EnvironmentDetailsDialog, ExportDialog,
ProfileCreationDialog, ProfileSelectorDialog, QueryHistoryDialog to
use FireAndForget.

Co-Authored-By: Claude Opus 4.6 &lt;noreply@anthropic.com&gt;
diff --git a/src/PPDS.Analyzers/Rules/NoFireAndForgetInCtorAnalyzer.cs b/src/PPDS.Analyzers/Rules/NoFireAndForgetInCtorAnalyzer.cs
@@ -67,6 +67,10 @@ private static void AnalyzeConstructor(SyntaxNodeAnalysisContext context)
             if (HasContinueWithErrorHandling(invocation))
                 continue;
 
+            // Skip if passed as argument to FireAndForget (centralized error handler)
+            if (IsArgumentToFireAndForget(invocation))
+                continue;
+
             var methodName = GetMethodName(invocation);
 
             var diagnostic = Diagnostic.Create(
@@ -168,6 +172,47 @@ private static bool HasContinueWithErrorHandling(InvocationExpressionSyntax invo
         return false;
     }
 
+    private static bool IsArgumentToFireAndForget(InvocationExpressionSyntax invocation)
+    {
+        // Check if this invocation is an argument to a FireAndForget call
+        // Pattern 1: _errorService.FireAndForget(SomeAsync(), "context")
+        // Pattern 2: _errorService?.FireAndForget(SomeAsync(), "context")
+        if (invocation.Parent is ArgumentSyntax argument &&
+            argument.Parent is ArgumentListSyntax argumentList)
+        {
+            // Direct call: errorService.FireAndForget(task, ...)
+            if (argumentList.Parent is InvocationExpressionSyntax outerInvocation)
+            {
+                var outerName = GetInvocationName(outerInvocation);
+                if (outerName == "FireAndForget")
+                    return true;
+            }
+
+            // Null-conditional call: errorService?.FireAndForget(task, ...)
+            // Syntax tree: ConditionalAccessExpression > InvocationExpression > ArgumentList
+            if (argumentList.Parent is InvocationExpressionSyntax conditionalInvocation &&
+                conditionalInvocation.Parent is ConditionalAccessExpressionSyntax)
+            {
+                var name = GetInvocationName(conditionalInvocation);
+                if (name == "FireAndForget")
+                    return true;
+            }
+        }
+
+        return false;
+    }
+
+    private static string? GetInvocationName(InvocationExpressionSyntax invocation)
+    {
+        return invocation.Expression switch
+        {
+            MemberAccessExpressionSyntax memberAccess => memberAccess.Name.Identifier.Text,
+            MemberBindingExpressionSyntax memberBinding => memberBinding.Name.Identifier.Text,
+            IdentifierNameSyntax identifier => identifier.Identifier.Text,
+            _ => null
+        };
+    }
+
     private static string GetMethodName(InvocationExpressionSyntax invocation)
     {
         return invocation.Expression switch
diff --git a/src/PPDS.Cli/Tui/Dialogs/ClearAllProfilesDialog.cs b/src/PPDS.Cli/Tui/Dialogs/ClearAllProfilesDialog.cs
@@ -21,6 +21,7 @@ namespace PPDS.Cli.Tui.Dialogs;
 internal sealed class ClearAllProfilesDialog : TuiDialog, ITuiStateCapture<ClearAllProfilesDialogState>
 {
     private readonly IProfileService _profileService;
+    private readonly ITuiErrorService? _errorService;
     private readonly TextField _confirmationField;
     private readonly Button _clearButton;
     private readonly int _profileCount;
@@ -40,6 +41,7 @@ public ClearAllProfilesDialog(IProfileService profileService, int profileCount,
         : base("Clear All Profiles", session)
     {
         _profileService = profileService ?? throw new ArgumentNullException(nameof(profileService));
+        _errorService = session?.GetErrorService();
         _profileCount = profileCount;
 
         Width = 65;
@@ -171,20 +173,7 @@ private void OnClearClicked()
         }
 
         // Perform the clear operation
-#pragma warning disable PPDS013 // Fire-and-forget with explicit error handling via ContinueWith
-        _ = PerformClearAsync().ContinueWith(t =>
-        {
-            if (t.IsFaulted && t.Exception != null)
-            {
-                Application.MainLoop?.Invoke(() =>
-                {
-                    MessageBox.ErrorQuery("Clear Failed",
-                        t.Exception.InnerException?.Message ?? t.Exception.Message,
-                        "OK");
-                });
-            }
-        }, TaskScheduler.Default);
-#pragma warning restore PPDS013
+        _errorService?.FireAndForget(PerformClearAsync(), "ClearAllProfiles");
     }
 
     private async Task PerformClearAsync()
diff --git a/src/PPDS.Cli/Tui/Dialogs/EnvironmentDetailsDialog.cs b/src/PPDS.Cli/Tui/Dialogs/EnvironmentDetailsDialog.cs
@@ -15,6 +15,7 @@ namespace PPDS.Cli.Tui.Dialogs;
 internal sealed class EnvironmentDetailsDialog : TuiDialog, ITuiStateCapture<EnvironmentDetailsDialogState>
 {
     private readonly InteractiveSession _session;
+    private readonly ITuiErrorService _errorService;
     private readonly string _environmentUrl;
     private readonly string? _environmentDisplayName;
     private readonly ITuiThemeService _themeService;
@@ -44,6 +45,7 @@ public EnvironmentDetailsDialog(
         string? environmentDisplayName = null) : base("Environment Details", session)
     {
         _session = session ?? throw new ArgumentNullException(nameof(session));
+        _errorService = session.GetErrorService();
         _environmentUrl = environmentUrl ?? throw new ArgumentNullException(nameof(environmentUrl));
         _environmentDisplayName = environmentDisplayName;
         _themeService = session.GetThemeService();
@@ -170,28 +172,7 @@ private void LoadDetailsAsync(CancellationToken cancellationToken)
         _refreshButton.Enabled = false;
         _statusLabel.Text = "Loading environment details...";
 
-#pragma warning disable PPDS013 // Fire-and-forget with explicit error handling
-        _ = LoadDetailsInternalAsync(cancellationToken).ContinueWith(t =>
-        {
-            Application.MainLoop?.Invoke(() =>
-            {
-                // Check _disposed before accessing token (CTS may be disposed)
-                if (_disposed)
-                {
-                    return;
-                }
-
-                _refreshButton.Enabled = true;
-
-                if (t.IsFaulted && t.Exception != null)
-                {
-                    var message = t.Exception.InnerException?.Message ?? t.Exception.Message;
-                    _statusLabel.Text = $"Error: {message}";
-                    _statusLabel.ColorScheme = TuiColorPalette.Error;
-                }
-            });
-        }, TaskScheduler.Default);
-#pragma warning restore PPDS013
+        _errorService.FireAndForget(LoadDetailsInternalAsync(cancellationToken), "LoadEnvironmentDetails");
     }
 
     private async Task LoadDetailsInternalAsync(CancellationToken cancellationToken)
diff --git a/src/PPDS.Cli/Tui/Dialogs/EnvironmentSelectorDialog.cs b/src/PPDS.Cli/Tui/Dialogs/EnvironmentSelectorDialog.cs
@@ -17,6 +17,7 @@ internal sealed class EnvironmentSelectorDialog : TuiDialog, ITuiStateCapture<En
     private readonly IEnvironmentService _environmentService;
     private readonly Action<DeviceCodeInfo>? _deviceCodeCallback;
     private readonly InteractiveSession? _session;
+    private readonly ITuiErrorService? _errorService;
     private readonly TextField _filterField;
     private readonly ListView _listView;
     private readonly Label _statusLabel;
@@ -59,6 +60,7 @@ public EnvironmentSelectorDialog(
         _environmentService = environmentService ?? throw new ArgumentNullException(nameof(environmentService));
         _deviceCodeCallback = deviceCodeCallback;
         _session = session;
+        _errorService = session?.GetErrorService();
 
         Width = 70;
         Height = 22;
@@ -177,21 +179,7 @@ public EnvironmentSelectorDialog(
         {
             _spinner.Start("Loading environments...");
 
-            // Discover environments asynchronously (fire-and-forget with error handling)
-#pragma warning disable PPDS013 // Fire-and-forget with explicit error handling via ContinueWith
-            _ = DiscoverEnvironmentsAsync().ContinueWith(t =>
-            {
-                if (t.IsFaulted && t.Exception != null)
-                {
-                    Application.MainLoop?.Invoke(() =>
-                    {
-                        _spinner.Stop();
-                        _statusLabel.Text = $"Error: {t.Exception.InnerException?.Message ?? t.Exception.Message}";
-                        _statusLabel.Visible = true;
-                    });
-                }
-            }, TaskScheduler.Default);
-#pragma warning restore PPDS013
+            _errorService?.FireAndForget(DiscoverEnvironmentsAsync(), "DiscoverEnvironments");
         };
     }
 
diff --git a/src/PPDS.Cli/Tui/Dialogs/ExportDialog.cs b/src/PPDS.Cli/Tui/Dialogs/ExportDialog.cs
@@ -17,6 +17,7 @@ internal sealed class ExportDialog : TuiDialog, ITuiStateCapture<ExportDialogSta
 {
     private static readonly IReadOnlyList<string> FormatNames = new[] { "CSV", "TSV", "JSON", "Clipboard" };
     private readonly IExportService _exportService;
+    private readonly ITuiErrorService? _errorService;
     private readonly DataTable _dataTable;
     private readonly IReadOnlyDictionary<string, QueryColumnType>? _columnTypes;
     private readonly RadioGroup _formatGroup;
@@ -50,6 +51,7 @@ public ExportDialog(
         InteractiveSession? session = null) : base("Export Results", session)
     {
         _exportService = exportService ?? throw new ArgumentNullException(nameof(exportService));
+        _errorService = session?.GetErrorService();
         _dataTable = dataTable ?? throw new ArgumentNullException(nameof(dataTable));
         _columnTypes = columnTypes;
 
@@ -228,24 +230,7 @@ private void ExportToFile(int format, bool includeHeaders)
         _statusLabel.Text = "Exporting...";
         Application.Refresh();
 
-#pragma warning disable PPDS013 // Fire-and-forget with explicit error handling
-        _ = ExportToFileAsync(filePath, format, includeHeaders).ContinueWith(t =>
-        {
-            Application.MainLoop?.Invoke(() =>
-            {
-                if (t.IsFaulted)
-                {
-                    _statusLabel.Text = $"Error: {t.Exception?.InnerException?.Message ?? "Export failed"}";
-                }
-                else
-                {
-                    _exportCompleted = true;
-                    MessageBox.Query("Export", $"Exported to:\n{filePath}", "OK");
-                    Application.RequestStop();
-                }
-            });
-        }, TaskScheduler.Default);
-#pragma warning restore PPDS013
+        _errorService?.FireAndForget(ExportToFileAsync(filePath, format, includeHeaders), "ExportToFile");
     }
 
     private async Task ExportToFileAsync(string filePath, int format, bool includeHeaders)
diff --git a/src/PPDS.Cli/Tui/Dialogs/ProfileCreationDialog.cs b/src/PPDS.Cli/Tui/Dialogs/ProfileCreationDialog.cs
@@ -32,6 +32,7 @@ internal sealed class ProfileCreationDialog : TuiDialog, ITuiStateCapture<Profil
     };
     private readonly IProfileService _profileService;
     private readonly IEnvironmentService _environmentService;
+    private readonly ITuiErrorService? _errorService;
     private readonly Action<DeviceCodeInfo>? _deviceCodeCallback;
 
     private readonly TextField _nameField;
@@ -87,6 +88,7 @@ public ProfileCreationDialog(
     {
         _profileService = profileService ?? throw new ArgumentNullException(nameof(profileService));
         _environmentService = environmentService ?? throw new ArgumentNullException(nameof(environmentService));
+        _errorService = session?.GetErrorService();
         _deviceCodeCallback = deviceCodeCallback;
 
         Width = 70;
@@ -405,9 +407,7 @@ private void OnAuthenticateClicked()
         _statusLabel.Text = "Authenticating...";
         Application.Refresh();
 
-#pragma warning disable PPDS013 // Fire-and-forget with explicit error handling
-        _ = CreateProfileAndHandleResultAsync(request, deviceCallback);
-#pragma warning restore PPDS013
+        _errorService?.FireAndForget(CreateProfileAndHandleResultAsync(request, deviceCallback), "CreateProfile");
     }
 
     private async Task CreateProfileAndHandleResultAsync(ProfileCreateRequest request, Action<DeviceCodeInfo>? deviceCodeCallback)
diff --git a/src/PPDS.Cli/Tui/Dialogs/ProfileDetailsDialog.cs b/src/PPDS.Cli/Tui/Dialogs/ProfileDetailsDialog.cs
@@ -283,20 +283,7 @@ public ProfileDetailsDialog(InteractiveSession session) : base("Profile Details"
             refreshButton, closeButton
         );
 
-        // Load profile data asynchronously
-#pragma warning disable PPDS013 // Fire-and-forget with explicit error handling via ContinueWith
-        _ = LoadProfileAsync().ContinueWith(t =>
-        {
-            if (t.IsFaulted && t.Exception != null)
-            {
-                _errorService.ReportError("Failed to load profile details", t.Exception, "ProfileDetails");
-                Application.MainLoop?.Invoke(() =>
-                {
-                    _profileNameLabel.Text = "Error loading profile (see F12 for details)";
-                });
-            }
-        }, TaskScheduler.Default);
-#pragma warning restore PPDS013
+        _errorService.FireAndForget(LoadProfileAsync(), "LoadProfile");
     }
 
     private async Task LoadProfileAsync()
@@ -450,15 +437,7 @@ private static string TruncateUrl(string url, int maxLength)
 
     private void OnRefreshClicked()
     {
-#pragma warning disable PPDS013 // Fire-and-forget with explicit error handling via ContinueWith
-        _ = LoadProfileAsync().ContinueWith(t =>
-        {
-            if (t.IsFaulted && t.Exception != null)
-            {
-                _errorService.ReportError("Failed to refresh profile", t.Exception, "ProfileRefresh");
-            }
-        }, TaskScheduler.Default);
-#pragma warning restore PPDS013
+        _errorService.FireAndForget(LoadProfileAsync(), "RefreshProfile");
     }
 
     /// <inheritdoc />
diff --git a/src/PPDS.Cli/Tui/Dialogs/ProfileSelectorDialog.cs b/src/PPDS.Cli/Tui/Dialogs/ProfileSelectorDialog.cs
@@ -15,6 +15,7 @@ internal sealed class ProfileSelectorDialog : TuiDialog, ITuiStateCapture<Profil
 {
     private readonly IProfileService _profileService;
     private readonly InteractiveSession? _session;
+    private readonly ITuiErrorService? _errorService;
     private readonly ListView _listView;
     private readonly Label _detailLabel;
     private readonly TuiSpinner _spinner;
@@ -51,6 +52,7 @@ public ProfileSelectorDialog(IProfileService profileService, InteractiveSession?
     {
         _profileService = profileService ?? throw new ArgumentNullException(nameof(profileService));
         _session = session;
+        _errorService = session?.GetErrorService();
 
         Width = 60;
         Height = 19;
@@ -172,23 +174,7 @@ public ProfileSelectorDialog(IProfileService profileService, InteractiveSession?
         {
             _spinner.Start("Loading profiles...");
 
-            // Load profiles asynchronously (fire-and-forget with error handling)
-#pragma warning disable PPDS013 // Fire-and-forget with explicit error handling via ContinueWith
-            _ = LoadProfilesAsync().ContinueWith(t =>
-            {
-                if (t.IsFaulted && t.Exception != null)
-                {
-                    Application.MainLoop?.Invoke(() =>
-                    {
-                        _spinner.Stop();
-                        _errorMessage = t.Exception.InnerException?.Message ?? t.Exception.Message;
-                        _detailLabel.Text = $"Error: {_errorMessage}";
-                        _detailLabel.Visible = true;
-                        _isLoading = false;
-                    });
-                }
-            }, TaskScheduler.Default);
-#pragma warning restore PPDS013
+            _errorService?.FireAndForget(LoadProfilesAsync(), "LoadProfiles");
         };
     }
 
@@ -391,20 +377,7 @@ private void ShowRenameDialog()
 
     private void PerformRename(ProfileSummary profile, string newName)
     {
-#pragma warning disable PPDS013 // Fire-and-forget with explicit error handling via ContinueWith
-        _ = PerformRenameAsync(profile, newName).ContinueWith(t =>
-        {
-            if (t.IsFaulted && t.Exception != null)
-            {
-                var ex = t.Exception.InnerException;
-                var message = ex is PpdsException ppdsEx ? ppdsEx.UserMessage : ex?.Message ?? "Unknown error";
-                Application.MainLoop?.Invoke(() =>
-                {
-                    MessageBox.ErrorQuery("Rename Failed", message, "OK");
-                });
-            }
-        }, TaskScheduler.Default);
-#pragma warning restore PPDS013
+        _errorService?.FireAndForget(PerformRenameAsync(profile, newName), "RenameProfile");
     }
 
     private async Task PerformRenameAsync(ProfileSummary profile, string newName)
@@ -446,18 +419,7 @@ private void OnDeleteClicked()
 
         if (result == 0) // "Delete" selected
         {
-#pragma warning disable PPDS013 // Fire-and-forget with explicit error handling
-            _ = DeleteProfileAsync(profile).ContinueWith(t =>
-            {
-                if (t.IsFaulted)
-                {
-                    Application.MainLoop?.Invoke(() =>
-                    {
-                        _detailLabel.Text = $"Error: {t.Exception?.InnerException?.Message ?? "Delete failed"}";
-                    });
-                }
-            }, TaskScheduler.Default);
-#pragma warning restore PPDS013
+            _errorService?.FireAndForget(DeleteProfileAsync(profile), "DeleteProfile");
         }
     }
 
diff --git a/src/PPDS.Cli/Tui/Dialogs/QueryHistoryDialog.cs b/src/PPDS.Cli/Tui/Dialogs/QueryHistoryDialog.cs
diff --git a/src/PPDS.Cli/Tui/Screens/SqlQueryScreen.cs b/src/PPDS.Cli/Tui/Screens/SqlQueryScreen.cs
